Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Supporting Vash (expressjs view-engine) #11068

Closed
dehghani-mehdi opened this issue Aug 28, 2016 · 6 comments
Closed

[Feature request] Supporting Vash (expressjs view-engine) #11068

dehghani-mehdi opened this issue Aug 28, 2016 · 6 comments
Labels
*extension-candidate Issue identified as good extension implementation

Comments

@dehghani-mehdi
Copy link

Hello,

I know there is tones of Feature requests, but because I love vscode, I want to this editor support everything !

If is possible please add syntax highlighting and intellisense for .vash files.

Thank you !

@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 28, 2016

Great idea to create the extension. I can create this extension tomorrow.

@sandy081 sandy081 added the *extension-candidate Issue identified as good extension implementation label Aug 29, 2016
@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 29, 2016

@mehdidehghani, I see that the syntax highlighting in the Sublime is outdated and, I think, that I'm able to write his own. You can provide any real file with Vash syntax for tests?

@dehghani-mehdi
Copy link
Author

As you know Vash engine offers Razor like syntax, so if you want something official, I think you need to take a look on Razor example in ASP.NET MVC, here is screenshot of a Razor file in VS2015:

untitled

The very important feature that you should care about in your extension, is mixing Vash + HTML in .vash files. and intellisense would be great too.

I'm looking forward to hear about your extension !

@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 31, 2016

@mehdidehghani,

First, sorry for delay, this is my first tmLanguage file and I need to understand how it works.

I published a preview version of extension to the VS Code marketplace. Now this extension support only syntax highlighting (HTML and JS in @keyword() and @{}) and Emmet (VS Code 1.5+).

About intellisense, please create an issue in the repository with a detailed description of what is meant by this term in the Vash.

https://github.com/mrmlnc/vscode-vash

@dehghani-mehdi
Copy link
Author

@mrmlnc, Don't worry, thanks for that, I just checked the preview and looks like you made it !!
I'm sorry, in your post, you mentioned VS Code +1.5, but current version of VS Code is 1.4, that was a mistyping or means I should wait for v1.5 for using the extension? =p

@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 31, 2016

@mehdidehghani, nope. Just Emmet will work only in version 1.5+. it's related to #9500.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*extension-candidate Issue identified as good extension implementation
Projects
None yet
Development

No branches or pull requests

3 participants