Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type ahead: don't predict when the first character on the line is : #109541

Closed
Tyriar opened this issue Oct 27, 2020 · 2 comments
Closed

Type ahead: don't predict when the first character on the line is : #109541

Tyriar opened this issue Oct 27, 2020 · 2 comments
Assignees
@Tyriar @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-local-echo Relating to the terminal's local echo and line editing for remote windows verified Verification succeeded
Milestone
October 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 27, 2020

Some programs like git log/less use the normal buffer, we should prevent predictions for this case where the line is not wrapped, starts with : and the cursor is on the second column (1 based).
recording (8)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Oct 27, 2020
@Tyriar Tyriar added the terminal-local-echo Relating to the terminal's local echo and line editing for remote windows label Oct 28, 2020
@Tyriar Tyriar added this to the October 2020 milestone Oct 28, 2020
@rzhao271 rzhao271 added the verification-steps-needed Steps to verify are needed for verification label Oct 29, 2020
@rzhao271
Copy link
Contributor

Not sure what the expected output is here.
If I run git log, and then try typing or holding down a, nothing happens.
I have local echo set to 0

@connor4312
Copy link
Member

That's expected -- you should not get predictions in git log

@rzhao271 rzhao271 added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Oct 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-local-echo Relating to the terminal's local echo and line editing for remote windows verified Verification succeeded
Projects
None yet
Milestone
October 2020
Development

No branches or pull requests
4 participants
@Tyriar @connor4312 @rzhao271 and others