Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended glob patter for findFiles #10851

Closed
wclr opened this issue Aug 23, 2016 · 3 comments
Closed

Extended glob patter for findFiles #10851

wclr opened this issue Aug 23, 2016 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality search Search widget and operation issues

Comments

@wclr
Copy link

wclr commented Aug 23, 2016

It seems that vscod.workspace.findFiles doesn't support extended patterns such as:

**/+(gulpfile.js|package.json) or '**/@(node_modules|jspm_packages|bower_components)/**'

http://www.linuxjournal.com/content/bash-extended-globbing

it is quite limiting.

@bpasero bpasero added feature-request Request for new features or functionality file-explorer Explorer widget issues and removed file-explorer Explorer widget issues labels Aug 24, 2016
@bpasero bpasero added this to the Backlog milestone Aug 24, 2016
@bpasero bpasero removed their assignment Aug 24, 2016
@wclr
Copy link
Author

wclr commented Aug 24, 2016

Or another proposal is to add ability for mult-pattern so it would be possible to pass array of simple patterns.

BTW findFIles works quite slowly is it because it checks all the nested folders and tests all files against exclude pattern?

@bpasero bpasero added search Search widget and operation issues and removed workbench labels Nov 16, 2017
@bpasero
Copy link
Member

bpasero commented Nov 16, 2017

Unlikely given that we now depend on RipGrep glob handling, but I let @roblourens decide

@roblourens
Copy link
Member

I opened this issue to allow passing an array of patterns: #38545. I much prefer that over supporting extended glob syntax.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants