Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font spacing has gone nuts on OSX (Since 1.49) #106552

Closed
Gruntfuggly opened this issue Sep 12, 2020 · 7 comments
Closed

Font spacing has gone nuts on OSX (Since 1.49) #106552

Gruntfuggly opened this issue Sep 12, 2020 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@Gruntfuggly
Copy link

I've just updated to 1.49 under OSX and the font spacing has increased:
image

I can recover the font in the main editor by setting the spacing to -5 but it doesn't work for the integrated terminal.

The font used is ProggyTiny, which was working perfectly up until this update. I use the same font under Ubuntu and there is no issue with 1.49.

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2020

Can you share your settings file?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Sep 14, 2020
@Gruntfuggly
Copy link
Author

{
    "Live-Workspace.username": "firsta12",
    "[c]": {
        "editor.quickSuggestions": false
    },
    "[cpp]": {
        "editor.quickSuggestions": false
    },
    "[javascript]": {
        "editor.defaultFormatter": "vscode.typescript-language-features"
    },
    "activitusbar.combineWorkspaceSettings": true,
    "activitusbar.mergeWorkspaceSettings": true,
    "activitusbar.searchViewInPanel": false,
    "activitusbar.toggleSidebar": false,
    "activitusbar.views": [
        {
            "codicon": "files",
            "name": "explorer"
        },
        {
            "codicon": "search",
            "name": "search"
        },
        {
            "codicon": "source-control",
            "name": "scm"
        },
        {
            "codicon": "debug-alt",
            "name": "debug"
        },
        {
            "codicon": "extensions",
            "name": "extensions"
        }
    ],
    "autoAlign.associations": {
        "bsv": "|",
        "csv": ",",
        "robot": "  "
    },
    "autoAlign.enabled": {
        "bsv": true,
        "csv": true,
        "md": true,
        "robot": true
    },
    "autoSnippet.commands": "editor.action.commentLine",
    "autoSnippet.debug": true,
    "autoSnippet.snippets": [
        {
            "commands": [
                "namespaceResolver.generateNamespace"
            ],
            "pattern": "**/*.php",
            "snippet": "basic-php"
        }
    ],
    "awooga.enabled": {
        "js": false
    },
    "awooga.location": "statusBar.background",
    "breadcrumbs.enabled": true,
    "breakpoint-sync.debug": true,
    "cSpell.allowCompoundWords": true,
    "cSpell.dictionaries": [
        "en-uk"
    ],
    "cSpell.userWords": [
        "activitus",
        "activitusbar",
        "behaviour",
        "gerrit",
        "gruntfuggly",
        "micromatch",
        "octicon",
        "octicons",
        "remembrall",
        "subfolders",
        "submodule",
        "submodules",
        "xmlns"
    ],
    "calendar.debug": true,
    "calendar.google.credentialsFile": "/Users/nige/.google.credentials.json",
    "calendar.google.useDefaultReminders": false,
    "calendar.historicDays": 1,
    "calendar.locale": "en-gb",
    "calendar.maxEvents": 50,
    "colorize.ignore_search_variables_info": true,
    "debug.inlineValues": true,
    "discord-chat.autoHide": 60,
    "discord-chat.autoShow": true,
    "discord-chat.compactView": true,
    "discord-chat.history": 30,
    "discord-chat.showUnreadOnly": true,
    "editor.autoClosingBrackets": "never",
    "editor.autoClosingQuotes": "never",
    "editor.cursorSurroundingLines": 2,
    "editor.detectIndentation": false,
    "editor.emptySelectionClipboard": false,
    "editor.fontSize": 11,
    "editor.formatOnPaste": true,
    "editor.formatOnSave": true,
    "editor.formatOnType": true,
    "editor.insertSpaces": true,
    "editor.matchBrackets": "never",
    "editor.minimap.enabled": false,
    "editor.renderControlCharacters": false,
    "editor.renderIndentGuides": true,
    "editor.renderWhitespace": "boundary",
    "editor.rulers": [
        80,
        120
    ],
    "editor.scrollBeyondLastLine": false,
    "editor.tabSize": 4,
    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "text.html.markdown.journal.task.open.bullet",
                "settings": {
                    "foreground": "#FFFF00"
                }
            },
            {
                "scope": "text.html.markdown.journal.task.open.marker",
                "settings": {
                    "foreground": "#FFFF00"
                }
            },
            {
                "scope": "text.html.markdown.journal.task.open.keyword",
                "settings": {
                    "fontStyle": "italic"
                }
            },
            {
                "scope": "text.html.markdown.journal.task.open.text",
                "settings": {}
            },
            {
                "scope": "text.html.markdown.journal.task.completed.keyword",
                "settings": {
                    "fontStyle": "italic"
                }
            },
            {
                "scope": "text.html.markdown.journal.task.completed.marker",
                "settings": {
                    "foreground": "#AAAAAA"
                }
            },
            {
                "scope": "text.html.markdown.journal.task.completed.text",
                "settings": {
                    "foreground": "#AAAAAA"
                }
            },
            {
                "scope": "text.html.markdown.journal.task.completed.bullet",
                "settings": {
                    "foreground": "#FFFF00"
                }
            },
            {
                "scope": "text.html.markdown.journal.memo.keyword",
                "settings": {
                    "fontStyle": "italic"
                }
            },
            {
                "scope": "text.html.markdown.journal.memo.bullet",
                "settings": {
                    "foreground": "#FFFF00"
                }
            },
            {
                "scope": "text.html.markdown.journal.scope",
                "settings": {
                    "foreground": "#FFFF00"
                }
            },
            {
                "scope": "text.html.markdown.journal.link.keyword",
                "settings": {
                    "fontStyle": "italic"
                }
            },
            {
                "scope": "text.html.markdown.journal.link.bullet",
                "settings": {
                    "foreground": "#FFFF00"
                }
            }
        ]
    },
    "editor.useTabStops": false,
    "extensions.ignoreRecommendations": true,
    "files.autoSave": "onWindowChange",
    "files.trimTrailingWhitespace": true,
    "format-modified.debug": true,
    "format-modified.formatWholeDocumentOnFailure": false,
    "format-modified.languages": [
        "javascript",
        "cpp"
    ],
    "formatOnIdle.enabled": {
        "js": true,
        "json": true
    },
    "gerrit-view.autoRefresh": 0,
    "gerrit-view.debug": true,
    "gerrit-view.server": "gerrit.asl.lan",
    "gerrit-view.treeConfigFile": "/Users/nige/Projects/vscode-extensions/gerrit-view/tree.json",
    "git-graph.commitDetailsViewLocation": "Docked to Bottom",
    "git-graph.dialog.resetCurrentBranchToCommit.mode": "Hard",
    "html.format.enable": false,
    "html.format.wrapLineLength": 160,
    "javascript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": false,
    "javascript.format.insertSpaceAfterKeywordsInControlFlowStatements": false,
    "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": true,
    "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": true,
    "javascript.format.placeOpenBraceOnNewLineForControlBlocks": true,
    "javascript.format.placeOpenBraceOnNewLineForFunctions": true,
    "markdown.preview.fontSize": 11,
    "remembrall.confirmRemove": false,
    "remembrall.debug": true,
    "remembrall.syncEnabled": true,
    "remotefs.remote": {
        "firstaidyogatraining.co.uk": {
            "host": "ftp.firstaidyogotraining.co.uk",
            "scheme": "ftp",
            "username": "firsta12"
        },
        "zaonce.com": {
            "host": "ftp.zaonce.com",
            "scheme": "ftp",
            "username": "zaoncecom"
        }
    },
    "rename-actions.debug": true,
    "rename-actions.watchers": [
        {
            "actions": [
                {
                    "regex": "class \\w+",
                    "snippet": "class ${TM_FILENAME_BASE}"
                }
            ],
            "excludes": [
                "**/.blade"
            ],
            "files": "**/*.php"
        }
    ],
    "rss.feeds": [
        "http://feeds.bbci.co.uk/news/uk/rss.xml",
        "https://www.dailygrail.com/feed/"
    ],
    "scoper.highlightColor": "#00330080",
    "search.collapseResults": "auto",
    "search.enableSearchEditorPreview": true,
    "searchRipgrep.enable": true,
    "sfmt.braces": "allman",
    "sfmt.insize": 4,
    "sftp.downloadWhenOpenInRemoteExplorer": true,
    "svgviewer.enableautopreview": true,
    "svgviewer.transparencycolor": "#222",
    "swap-and-paste.copyCommand": "clipring.copyToRing",
    "swap-and-paste.cutCommand": "clipring.cutToRing",
    "swap-and-paste.debug": true,
    "terminal.integrated.fontSize": 12,
    "terminal.integrated.shell.osx": "/bin/bash",
    "terminal.integrated.shellArgs.osx": [
        "-l"
    ],
    "timeline.pageOnScroll": true,
    "timeline.showView": true,
    "todo-tree.general.debug": true,
    "trailing-spaces.backgroundColor": "rgba(0,0,255,0.0)",
    "trailing-spaces.borderColor": "rgba(255,100,100,0.0)",
    "triggerTaskOnSave.on": true,
    "triggerTaskOnSave.restart": true,
    "triggerTaskOnSave.tasks": {
        "ut": [
            "**/*.js"
        ]
    },
    "ubertab.shouldIndent": true,
    "vscode-journal-view.debug": true,
    "vscode-journal-view.showInExplorer": true,
    "vscode-journal-view.showNonJournalFiles": true,
    "window.newWindowDimensions": "inherit",
    "window.restoreWindows": "folders",
    "window.title": "${activeEditorLong}${separator}${rootName}",
    "window.titleBarStyle": "custom",
    "window.zoomLevel": 0,
    "windowColors.theme": "dark",
    "workbench.activityBar.visible": true,
    "workbench.colorCustomizations": {
        "activityBar.background": "#000000",
        "activityBar.border": "#101010",
        "editor.background": "#000",
        "editor.selectionBackground": "#0000ff",
        "editorRuler.foreground": "#202020",
        "sideBar.background": "#111",
        "sideBar.border": "#101010",
        "statusBar.background": "#111",
        "statusBar.border": "#101010"
    },
    "workbench.editor.showTabs": false,
    "workbench.fontAliasing": "antialiased",
    "workbench.settings.useSplitJSON": true,
    "workbench.startupEditor": "newUntitledFile",
    "workbench.view.experimental.allowMovingToNewContainer": true,
    "todo-tree.highlights.enabled": true,
    "todo-tree.tree.showCountsInTree": true,
    "todo-tree.tree.showScanModeButton": true,
    "todo-tree.highlights.highlightDelay": 200,
    "todo-tree.highlights.defaultHighlight": {
        "type": "tag",
        "background": "#f00",
        "foreground": "#0a0",
        "opacity": 50
    },
    "todo-tree.general.tags": [
        "BUG",
        "HACK",
        "FIXME",
        "TODO",
        "XXX"
    ],
    "todo-tree.filtering.includeHiddenFiles": false,
    "todo-tree.filtering.ignoreGitSubmodules": true,
    "editor.lineHeight": 14,
    "editor.fontFamily": "ProggyTiny, Menlo, Monaco, 'Courier New', monospace",
    "editor.letterSpacing": -5,
    "terminal.integrated.fontFamily": "ProggyTiny",
    "todo-tree.tree.sortTagsOnlyViewAlphabetically": true
}

@Gruntfuggly
Copy link
Author

Sorry - there's a lot of stuff in there!

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2020

I've seen Chromium-related issues with a Proggy font before in the terminal #84432, I'm guessing this is related to the Electron 9 update.

@Tyriar Tyriar assigned deepak1556 and unassigned Tyriar Sep 14, 2020
@Tyriar Tyriar removed the info-needed Issue requires more information from poster label Sep 14, 2020
@pavlos256
Copy link

pavlos256 commented Sep 21, 2020

I have the same issue on Linux but only on the terminal. Not using the Proggy font.

code

Edit: Setting a different front for the terminal via "terminal.integrated.fontFamily": "Consolas" fixed it. It seems the font used for the editor has problems when used on the terminal: "PxPlus IBM VGA 8x16".

@deepak1556
Copy link
Collaborator

/duplicate #84432

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants
@pavlos256 @Gruntfuggly @deepak1556 @Tyriar and others