Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowsShellHelper should be available on the extension host as well #106354

Closed
Tyriar opened this issue Sep 9, 2020 · 0 comments · Fixed by #118252
Closed

WindowsShellHelper should be available on the extension host as well #106354

Tyriar opened this issue Sep 9, 2020 · 0 comments · Fixed by #118252
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues windows VS Code on Windows issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2020

Currently WindowsShellHelper runs on the renderer process and it is used to classify the current shell on Windows which drives the terminalShellType context key for keybindings as well as the terminal name that shows up in the dropdown. This has always been a debt item that it should be running on the extension host for the remote use case but has never been high priority since it's a small feature that it supports and Windows SSH is fairly new is not a big share of our remote-ssh usage.

This would ideally move to where ever ends up hosting node-pty after the item in #92164 is done.

@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues windows VS Code on Windows issues labels Sep 9, 2020
@Tyriar Tyriar added this to the Backlog milestone Sep 9, 2020
@Tyriar Tyriar self-assigned this Sep 9, 2020
@Tyriar Tyriar modified the milestones: Backlog, March 2021 Mar 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Tyriar and others