findTextInFiles fails on redundant glob

[connor4312]

Refs #104648 (comment)

There's an outfile pattern that we compile to new RelativePattern('<workspaceFolder>', 'dist/**/*.js, dist/*.js'). This fails to match anything, but new RelativePattern('<workspaceFolder>', 'dist/**/*.js') works.

Complete options:

findTextInFiles(
  { pattern: 'sourceMappingURL', isCaseSensitive: true },
  {
    include: {
      base: "E:\\TestBed\\vscode-ts-debug-failure",
      pattern: "dist/**/*.js, dist/*.js",
    },
    exclude: "",
    useDefaultExcludes: false,
    useIgnoreFiles: false,
    useGlobalIgnoreFiles: false,
    followSymlinks: true,
    beforeContext: 0,
    afterContext: 0,
    previewOptions: {
      charsPerLine: 9007199254740991,
      matchLines: 1,
    },
  },
)

[roblourens]

Should it be wrapped in {}?

[connor4312]

We use new RelativePattern -- this was just the result of me copying the options directly from the debugger https://github.com/microsoft/vscode-js-debug/blob/7dd5107733e7982888c129279c06cf13da6c4f93/src/common/sourceMaps/codeSearchStrategy.ts#L86

[roblourens]

Yeah but I think that if you want that second argument to be parsed as a list, it needs to be wrapped in curly braces.

[connor4312]

As in {dist/**/*.js, dist/*.js}?

[roblourens]

Yeah

[connor4312]

Ok. Is that something we should do for all patterns? That is, change

forceForwardSlashes(files.patterns.filter(p => !p.startsWith('!')).join(', ')),

to

'{'+ forceForwardSlashes(files.patterns.filter(p => !p.startsWith('!')).join(', ')) + '}'

[roblourens]

I believe so. Are they working as is?

[connor4312]

Yea, it works in general, just not this case. I'll give it a shot.

[connor4312]

It seems like ripgrep doesn't like that, {**/*.js, out/*.js} and {**/*.js} don't match any files

[connor4312]

This also seems to fail if the pattern base is a workspace folder and the pattern navigates outside of it (e.g. ../foo/**/*.js)