timeout after 1000 ms

[ati0ns]

• VSCode Version: I do not know.
• OS Version: What is this ?

Steps to Reproduce:

1. Start the debugger.
2. Stop it.

Does this issue occur when all extensions are disabled?: Yes/No
Probably.

[weinand]

/needsMoreInfo

If you use the "Report Issue" command from VS Code's Help menu, it will automatically fill in the version number and OS information into the issue.

What debugger are you talking about?

[gjsjohnmurray]

Mentioned by @joaomoreno in #100368 (comment)

[ati0ns]

[weinand]

You said:

Start the debugger.

Since you have C++, C#, Python, PHP, Java, and JS debuggers installed, I do not know what "debugger" you mean.

Please provide more details.

[joaomoreno]

@weinand, @gjsjohnmurray is 100% correct.

You can easily reproduce this by following my steps in #100368 (comment) on our selfhost setup.

[yannickowow]

Hi
I have the same behavior with my own Debug Adapter or with CppTools with custom GDB
With my adapter and my GDB, close can take a time (more than 1000 ms), because it uses subcomponents. From my side, this error happens when Code does not wait for disconnectRequest response.

Where this timeout came from ?

Thanks in advance.

[connor4312]

I see the assignment to Isi but I think this should be closed as an extension issue, unless the UX is under question. When this is hit in js-debug, it's a result of the extension not responding to the disconnect request soon enough, which is an extension issue.

[weinand]

If extensions have difficulties to respond to the disconnect request is time, then we should relax that requirement on the VS Code side by either extending the timeout or by ignoring any errors completely.
And if we agree that the timeout is valid, then we should improve the error message so that users can understand the reason for the message.

[isidorn]

I do not see big value in showing the timeout error to the user. Thus I have pushed the following change:

1. Increased timeout from 1s to 2s
2. Not showing the error in the case that the debug adapter is going down
3. Changed the timeout message to be localized (will not affect this case since we do not show the error now)

[connor4312]

I do not see big value in showing the timeout error to the use

Imo it's the same as the typescript server has crashed errors -- not necessarily useful to the user, but a nag for extension authors. If it's just a console log most developers will probably ignore it.

[isidorn]

I see. However still prefer to optimise for the users.

[Zuckjet]

timeout after 1000 ms error occurred frquently.

• VSCode Version:
  Version: 1.48.0 (user setup)
  Commit: db40434
  Date: 2020-08-13T07:50:42.600Z
  Electron: 7.3.2
  Chrome: 78.0.3904.130
  Node.js: 12.8.1
  V8: 7.8.279.23-electron.0
  OS: Windows_NT x64 10.0.18363

• OS Version:
  Edition: Windows 10 Home
  Version: 1909
  OS Build: 18363.1016

My vscode launch.json file:

            "name": "Launch via NPM",
            "type": "node",
            "request": "launch",
            "cwd": "${workspaceRoot}",
            "runtimeExecutable": "npm.cmd",
            "stopOnEntry": true,
            "runtimeArgs": [
                "run-script", "debug"
            ],
            "port": 5858,

I also tried to add timeout option to fix the error, but not working.

My vscode only installed one debugger extension, which is "Debugger for chrome".

Everytime this error occurred , my vscode cannot debug anymore, and I have to restart vscode, but after a time , it occurred again.

[connor4312]

This fix is so far only on VS Code Insiders: https://code.visualstudio.com/insiders/

[Zuckjet]

This fix is so far only on VS Code Insiders: https://code.visualstudio.com/insiders/

Thanks, I will try this version.