Reveal in Finder not working if Finder is closed

[normalser]

• VSCode Version: 1.4.0-insiders
• OS Version: OSX 10.11.6 (15G31)

Steps to Reproduce:

1. Quit Finder
   
2. Use Command Palette and select Reveal Active File in Finder - problem - nothing will happen
3. Use CMD+K R combination - problem - status bar will show:
   

PS. Sublime can handle that case

[kieferrm]

@wallverb the command is ⌘K R. It's correct that ⌘K ⌘R is not a command.

[normalser]

Right, sorry, point #3 is invalid then, CMD+K R in this case does nothing (similar to Command Palette Reveal Active File in Finder).Thanks

[bpasero]

An electron issue, we use their method to show an item in the finder.

[bpasero]

@wallverb could you give our insider release a try to see if this issue is fixed?
You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

[normalser]

@bpasero Still the same issue with insiders @ 0619ede - although Atom also does not handle this case (only Sublime does) - so must be Electron issue

[bpasero]

Got it. I suggest to let Electron know with an issue and link it here.

[wangweixuan]

Electron API showItemInFolder in fact returns a boolean. But we don't use that result(windowService.ts), so when the action fails you won't get any feedback.
I think we should handle its result just like what we do for openExternal, so that me can at least show a failure message in this case.

In addition, quitting Finder isn't recommended. I tried to do this and then apply 'Reveal in Finder' at an app in the Dock, but nothing happened as well.

[bpasero]

That seems possible, PR welcome.

[trivikr]

While debugging this issue, I put breakpoints at https://github.com/Microsoft/vscode/blob/39130b09e65865fd2fcaf0d4cb8dd3c6fb6da7a6/src/vs/platform/windows/common/windowsIpc.ts#L301-L303

The _state in return value contains "success" even when the Finder is not available

[vscodebot]

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!