Notebook editor layout glitch while resizing

[roblourens]

Seems like the basic issue is that here, we are using the old scrollWidth to compute the new height, with the new total width, so when sizing the editor to be smaller, scrollWidth is always > width. I see the same wrong computation in a basic text editor, but I guess it's not a problem when the height is wrong there.

vscode/src/vs/editor/common/viewLayout/viewLayout.ts

Line 218 in b95c725

this._getContentHeight(width, height, scrollWidth)

This fixes it

but I really have no clue if that's the right thing to do, also scrollWidth is used in _updateHeight. I think that's ok because that's not called when these numbers are changing so scrollWidth will just be equal to contentWidth or width.

[roblourens]

@rebornix I think I've done all the debugging I can do on this. The change in my screenshot might be enough or it might break stuff. Do you have any idea or should we loop in Alex?

[rebornix]

thanks for the investigation, @alexdima can you confirm if it's safe?

[alexdima]

👍 The analysis is very good and that change makes good sense.