From 0a778a5d15256bedfe0130392042b40a387f9a8b Mon Sep 17 00:00:00 2001 From: Joyce Er Date: Wed, 26 Apr 2023 15:41:36 -0700 Subject: [PATCH] Allow clicking to remove breakpoint even alongside non debug decorations (#180986) --- .../debug/browser/breakpointEditorContribution.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts b/src/vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts index 116ad8906ae87..58aa738509680 100644 --- a/src/vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts +++ b/src/vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts @@ -258,7 +258,14 @@ export class BreakpointEditorContribution implements IBreakpointEditorContributi } const model = this.editor.getModel(); - if (!e.target.position || !model || e.target.type !== MouseTargetType.GUTTER_GLYPH_MARGIN || e.target.detail.isAfterLines || !this.marginFreeFromNonDebugDecorations(e.target.position.lineNumber)) { + if (!e.target.position + || !model + || e.target.type !== MouseTargetType.GUTTER_GLYPH_MARGIN + || e.target.detail.isAfterLines + || !this.marginFreeFromNonDebugDecorations(e.target.position.lineNumber) + // don't return early if there's a breakpoint + && !e.target.element?.className.includes('breakpoint') + ) { return; } const canSetBreakpoints = this.debugService.canSetBreakpointsIn(model);