Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back slashes are not saved in User field when adding a new connection #6172

Closed
Tracked by #7321
byamagata opened this issue Jan 14, 2022 · 4 comments
Closed
Tracked by #7321
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug ssh Issue in vscode-remote SSH verified Verification succeeded
Milestone

Comments

@byamagata
Copy link

  • VSCode Version: 1.63.2
  • Local OS Version: 10.0.19042
  • Remote OS Version: 10.0.2294
  • Remote Extension/Connection Type: SSH/Docker/WSL
  • Logs:

Steps to Reproduce:

  1. Open Command Palette
  2. Select Remote SSH: Add New SSH Host
  3. When prompted to enter your ssh connection command, enter a username that contains a backslash. (For instance, I added my username: nv\byamagata)
  4. Save to any config
  5. Open Config and backslash is missing from the User field of the newly created connection

image

Does this issue occur when you try this locally?: Yes
Does this issue occur when you try this locally and all extensions are disabled?: Yes

@github-actions github-actions bot added the ssh Issue in vscode-remote SSH label Jan 14, 2022
@tanhakabir tanhakabir added the bug Issue identified by VS Code Team member as probable bug label Jan 20, 2022
@tanhakabir tanhakabir self-assigned this Jan 20, 2022
@byamagata
Copy link
Author

@tanhakabir have you made any progress with this? It's not a huge issue, just requires you to manually modify the config file. Was more just curious because I ran into it again right now.

@tanhakabir
Copy link

No sorry I haven't, I wanted to investigate SSH man first to verify what characters are and aren't permitted.

But afterwards it just requires a PR of a fix in one of our dependencies.

@eleanorjboyd
Copy link
Member

Hello @byamagata, I was going in to repro this issue and then fix it but it seems to now work for me to include a slash in the username. I used the command Add New SSH Host then entered ssh aa/bb@locahost which showed up correctly in my config file and ssh localhost -l aa/bb which showed up with the backslash as well. Could you retry adding a connection with the slash to see if it is fixed or if your problem still persists? If it still persists if you could send the exact string you pass into Add New SSH Host that would be great. Thanks!

@eleanorjboyd
Copy link
Member

Hello! Upon further evaluation we have determined that this will no longer be a plan item we implement. In order to keep our parsing from the Add New SSH Host command straightforward, these commands must follow bash parsing rules. Feel free to look into bash escape characters and use them to get a slash into your config file. Thanks!

@eleanorjboyd eleanorjboyd closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
@mjbvz mjbvz added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug ssh Issue in vscode-remote SSH verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants