Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No parameter config equivalent to --ssh default in build parameters to support pip ssh requirements installations #5855

Closed
highronn opened this issue Nov 10, 2021 · 4 comments
Labels
containers Issue in vscode-remote containers *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@highronn
Copy link

When I build my dev container image I need to install some python requirements through pip that reference a specific repository commit.
To do so when I build my image myself I just need to pass --ssh default to my docker build command in order to use any ssh key declared via ssh-add command.
I've red the doc and didn't find any way to specify at build time this argument.
Do you think its possible to add this functionality?
I'm genuinely inclined to do if you give me some guidance on where to do it :D

@Chuxel Chuxel transferred this issue from microsoft/vscode-dev-containers Nov 10, 2021
@Chuxel Chuxel added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Nov 10, 2021
@Chuxel
Copy link
Member

Chuxel commented Nov 10, 2021

This sounds one of the use cases for #4352 on the surface since the same scenario is mentioned there. However, we could keep this open for a specific property and for consideration for the dev container CLI. Thoughts @chrmarti ?

@highronn
Copy link
Author

highronn commented Nov 10, 2021

Actually - I found this issue proposing to solve the problem in a more generic way. If you think its better to do it the generic way, I can put an eye on it.

@Chuxel
Copy link
Member

Chuxel commented Nov 10, 2021

Makes sense. Let's close this as a dupe of #3545.

@Chuxel Chuxel closed this as completed Nov 10, 2021
@Chuxel Chuxel added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants
@Chuxel @highronn and others