Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document formatting broken in 2018.12.1 #4138

Closed
klingtnet opened this issue Jan 24, 2019 · 3 comments
Closed

Document formatting broken in 2018.12.1 #4138

klingtnet opened this issue Jan 24, 2019 · 3 comments
Assignees
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@klingtnet
Copy link

klingtnet commented Jan 24, 2019

Environment data

  • VS Code version: 1.30.2
  • Extension version (available under the Extensions sidebar): 2018.12.0
  • OS and version: Linux kn-workstation 4.20.3-arch1-1-ARCH 1228 multi root master #1 SMP PREEMPT Wed Jan 16 22:38:58 UTC 2019 x86_64 GNU/Linux
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7.2
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
  • Relevant/affected Python packages and their versions: none

Expected behaviour

Formatting of python documents does not work anymore, since version 2018.12.1, instead it shows There is no document formatter for 'python'-files installed. I tried autopep8, yapf and black, all installed in the virtual environment.

Actual behaviour

Downgrading to 2018.12.0 fixes the issue.

Steps to reproduce:

  1. Upgrade to 2018.12.1 and try to format a Python file.

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

Starting Jedi Python language engine.
##########Linting Output - pylint##########
##########Linting Output - pylint##########

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

None
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 24, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 28, 2019
@DonJayamanne DonJayamanne added the important Issue identified as high-priority label Jan 28, 2019
@d3r3kk
Copy link

d3r3kk commented Jan 30, 2019

Thanks for the report @klingtnet. Unfortunately I cannot seem to reproduce your issue on Ubuntu 18.10 with the same VS Code and extension installed.

If you update to our latest version (2019.1) does the issue persist?

@d3r3kk d3r3kk added bug Issue identified by VS Code Team member as probable bug area-formatting info-needed Issue requires more information from poster labels Jan 30, 2019
@klingtnet
Copy link
Author

klingtnet commented Jan 30, 2019

It works again with vs-code 1.30.2 and python 2019.1 🎉 . Any idea what has caused the regression?

@d3r3kk
Copy link

d3r3kk commented Jan 30, 2019

Any idea what has caused the regression?

Well, not really, without seeing further information on your specific setup with regard to autopep8/yapf/black and Python.

Since I couldn't repro it, and since we weren't getting inundated with many reports of this bug, I believe it's probably limited to something unique on your particular environment though.

The only thing I can see that might add unknown variables in your setup at the moment is the Linux version, but I cannot explain what the trouble may have been at this point.

Thanks for getting back to us, it's great to see you up and running!

@d3r3kk d3r3kk closed this as completed Jan 30, 2019
@ghost ghost removed info-needed Issue requires more information from poster triage labels Jan 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants