Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support REPL input #23335

Closed
Tracked by #23332
amunger opened this issue May 5, 2024 · 3 comments
Closed
Tracked by #23332

support REPL input #23335

amunger opened this issue May 5, 2024 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@amunger
Copy link

amunger commented May 5, 2024

We need to be able to handle when user types input() and be able to wait for user to type their Python command.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 5, 2024
@amunger amunger changed the title support REPL input - @anthonykim1 support REPL input May 5, 2024
@amunger amunger added feature-request Request for new features or functionality and removed triage-needed Needs assignment to the proper sub-team labels May 5, 2024
@anthonykim1
Copy link

anthonykim1 commented May 10, 2024

microsoft/vscode#212427 may be necessary for this need to happen.
We also discussed how Jupyter extension handles input() via attaching cell below where input() is ran, but had some visibility complains. I'm still go see how we would be able to handle and signal to wait assuming that we would eventually have access to user text input box.

Perhaps we could even call it inside execute-handler as well since input() itself would not add cell output? - for the purposes of MVP
Edit: This is not possible since it DOES append cell output of EOF when reading line when we execute input()

  File "/Users/anthonykim/Desktop/vscode-python/python_files/python_server.py", line 56, in exec_user_input
    retval = callable(user_input, user_globals)
  File "<string>", line 1, in <module>
EOFError: EOF when reading a line

@amunger
Copy link
Author

amunger commented May 10, 2024

Jupyter handles this with an input opened at the top of the window (where quick picks show up), not an extra cell.

image

@anthonykim1
Copy link

Input is supported. Also input with prompts from a2208ca

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants