Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically handle test framework on activation #23234

Closed
karthiknadig opened this issue Apr 14, 2024 · 5 comments · Fixed by #24385
Closed

Dynamically handle test framework on activation #23234

karthiknadig opened this issue Apr 14, 2024 · 5 comments · Fixed by #24385
Assignees
@eleanorjboyd
Labels
area-testing feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2024

Comments

@karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added feature-request Request for new features or functionality area-testing needs PR Ready to be worked on labels Apr 14, 2024
@karthiknadig karthiknadig added this to the April 2024 milestone Apr 14, 2024
@joaomoreno joaomoreno mentioned this issue Apr 16, 2024
Closed
18 tasks
@eleanorjboyd eleanorjboyd modified the milestones: April 2024, May 2024 Apr 22, 2024
@eleanorjboyd eleanorjboyd mentioned this issue Apr 22, 2024
Closed
@kieferrm kieferrm mentioned this issue May 6, 2024
Closed
29 tasks
@luabud luabud modified the milestones: May 2024, June 2024 May 27, 2024
@kieferrm kieferrm mentioned this issue Jun 12, 2024
Closed
20 tasks
@karthiknadig karthiknadig modified the milestones: June 2024, July 2024 Jun 24, 2024
@eleanorjboyd
Copy link
Member

as an FYI this is getting postponed until the custom config work is done as these are deeply interconnected.

@eleanorjboyd eleanorjboyd removed this from the July 2024 milestone Jun 27, 2024
@eleanorjboyd eleanorjboyd mentioned this issue Sep 25, 2024
Closed
@kieferrm kieferrm mentioned this issue Oct 6, 2024
Closed
27 tasks
@kieferrm kieferrm mentioned this issue Nov 3, 2024
Closed
31 tasks
@eleanorjboyd eleanorjboyd mentioned this issue Nov 4, 2024
Merged
@eleanorjboyd
Copy link
Member

planning on a notification message to surface the error in the meantime (before the config stuff)

doing this will fix #21688

@karthiknadig karthiknadig added this to the November 2024 milestone Dec 2, 2024
@eleanorjboyd
Copy link
Member

Verification Steps:

  1. open or create a workspace with python files
  2. go to the testing tab to configure tests
  3. go through configure flow, select unittest then whichever other settings
  4. wait till discovery happens, check that you see an error message like- "testing framework incompatible"
  5. reload the window, verify you don't see this error message anymore

@karthiknadig karthiknadig added the verification-needed Verification of issue is requested label Dec 3, 2024
@DonJayamanne DonJayamanne added the verified Verification succeeded label Dec 4, 2024
@DonJayamanne
Copy link

No error message, but no tests discovered either.
Not sure thats expected.
Image

@eleanorjboyd
Copy link
Member

@DonJayamanne did you go through the configuration flow and still didn't see it? So the "configure python tests" button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleanorjboyd eleanorjboyd

Labels
area-testing feature-request Request for new features or functionality needs PR Ready to be worked on verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2024
4 participants
@DonJayamanne @karthiknadig @eleanorjboyd @luabud