-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for terminate requests or configurable termination signal for running sessions #21605
Comments
If either of these seem worthwhile, I'd be more than happy to submit a PR implementing the feature as I love the IDE, love this plugin and would love to contribute back. |
Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue. |
@benfiola This probably needs to be updated over in Here is the code where this is handled on This will need a setting added to the launch configuration (in python extension), and it will have to be passed through from |
Thank you for submitting your feature request and everyone who considered it! Unfortunately, this issue did not receive enough votes over the allotted time, and so we are closing the issue. |
Original discussion for context.
It appears that when terminating a running Python session - a SIGKILL is sent to the underlying process. While this does indeed kill the underlying process, it also prevents any sort of clean-up behavior (i.e., context managers, signal handlers, etc.).
It'd be great if I could either:
The text was updated successfully, but these errors were encountered: