Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor multi-step input implemenation to handle special cases #20696

Closed
karthiknadig opened this issue Feb 14, 2023 · 2 comments
Closed

Refactor multi-step input implemenation to handle special cases #20696

karthiknadig opened this issue Feb 14, 2023 · 2 comments
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Feb 14, 2023 •
edited
Loading

  1. Ensure that both QuickPick and QuickInput support cancellation or user pressing escape as CancellationError.
  2. Ensure that on step back, right context is passed back to multi-step runner.
  3. Ensure that there is a consistent way to handle Back when using QuickPick or QuickInput.
  4. hide() on a QuickPick without accept should result in CancellationError.
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 14, 2023
@karthiknadig karthiknadig added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Feb 14, 2023
@karthiknadig karthiknadig mentioned this issue Feb 14, 2023
Merged
@karthiknadig karthiknadig added area-internal Label for non-user facing issues needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Feb 14, 2023
@eleanorjboyd
Copy link
Member

@karthiknadig - thoughts here? Still needed?

@karthiknadig
Copy link
Member Author

This can be closed.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karthiknadig @eleanorjboyd