Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvironmentsChangedParams does not support conda envs with the same interpreter path #18734

Closed
DonJayamanne opened this issue Mar 21, 2022 · 1 comment
Assignees

Comments

@DonJayamanne
Copy link

DonJayamanne commented Mar 21, 2022

Testing #18727

When using two conda envs with the same interpreter path, the following event must support the new type EnvPathType

  • EnvironmentsChangedParams

Else its not possible to know what got updated, as the path isn't the key anymore

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 21, 2022
@karrtikr
Copy link

path here can refer to the path to environment folder, as the API doc says:

export interface EnvironmentsChangedParams {
/**
* Path to environment folder or path to interpreter that uniquely identifies an environment.
* Virtual environments lacking an interpreter are identified by environment folder paths,
* whereas other envs can be identified using interpreter path.
*/
path?: string;
type: 'add' | 'remove' | 'update' | 'clear-all';
}

So the envs are still distinguishable.

@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Mar 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants