Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move interpreter info status bar item to the right #18710

Closed
karrtikr opened this issue Mar 17, 2022 · 5 comments · Fixed by #18711
Closed

Move interpreter info status bar item to the right #18710

karrtikr opened this issue Mar 17, 2022 · 5 comments · Fixed by #18711
Assignees
@luabud
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2022

Comments

@karrtikr
Copy link

karrtikr commented Mar 17, 2022 •
edited
Loading

image

We eventually plan to move it into the language status item #18283, we're moving it to the right so users know to look towards the right side to find this information once #18283 is done.
@karrtikr karrtikr added feature-request Request for new features or functionality needs PR area-environments Features relating to handling interpreter environments labels Mar 17, 2022
@karrtikr karrtikr self-assigned this Mar 17, 2022
@karrtikr karrtikr mentioned this issue Mar 17, 2022
Merged
@karrtikr karrtikr added this to the March 2022 milestone Mar 17, 2022
@karrtikr karrtikr mentioned this issue Mar 17, 2022
Closed
@luabud luabud reopened this Mar 18, 2022
@luabud
Copy link
Member

luabud commented Mar 18, 2022

@karrtikr I reopened this one as the other one was closed, is that ok?

@karrtikr
Copy link
Author

karrtikr commented Mar 18, 2022 •
edited
Loading

This has already been merged in main (see referenced PR #18711) so this can be closed.

@luabud
Copy link
Member

luabud commented Mar 18, 2022

oh but we haven't shipped the experiment to 100% of users and removed the experiment as a whole yet. The issue I had opened before was for that 😅

@karrtikr
Copy link
Author

Oh do you mean we should remove the experiment from the experiment tower? Yes that hasn't been done yet. The work I did only removes all experiments in 'main'.

@karrtikr karrtikr assigned luabud and unassigned karrtikr Mar 19, 2022
@karrtikr karrtikr reopened this Mar 19, 2022
@luabud luabud closed this as completed Mar 21, 2022
@karrtikr karrtikr added the verification-needed Verification of issue is requested label Mar 21, 2022
@karrtikr
Copy link
Author

Verification steps:

  • Use pre release build of the extension.
  • Ensure it appears in the right: image
  • It only appears when either settings.json or a Python file is opened.

@jrieken jrieken added the verified Verification succeeded label Mar 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luabud luabud

Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

Successfully merging a pull request may close this issue.

Move interpreter info status bar item to the right karrtikr/vscode-python
3 participants
@jrieken @karrtikr @luabud