Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test public APIs for python environments #18348

Closed
2 tasks done
karthiknadig opened this issue Jan 24, 2022 · 2 comments
Closed
2 tasks done

Test public APIs for python environments #18348

karthiknadig opened this issue Jan 24, 2022 · 2 comments
Labels
testplan-item verified Verification succeeded
Milestone

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Jan 24, 2022

Refs: #17905

Complexity: 5

Create Issue


Requirements

  1. Use Insiders build of the python extension

Test APIs exposed via IProposedExtensionAPI

See IProposedExtensionAPI for APIs to test.

export interface IProposedExtensionAPI {

Example usage:
Copy over contents of https://github.com/microsoft/vscode-python/blob/fa169707810b405e8b227429e3a060959eab8ffb/src/client/apiTypes.ts as needed.

const extension = extensions.getExtension('ms-python.python');
if (extension) {
    if (!extension.isActive) {
        await extension.activate();
    }
    const api: IExtensionApi & IProposedExtensionAPI = extension.exports as IExtensionApi & IProposedExtensionAPI;
    if (api.environment) {
        interpreterPath = await api.environment.getActiveInterpreterPath();
    }
}
@karthiknadig karthiknadig added this to the January 2022 milestone Jan 24, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jan 24, 2022
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Jan 24, 2022
@ghost ghost assigned rchiodo and DonJayamanne Jan 25, 2022
@rchiodo rchiodo removed their assignment Jan 25, 2022
@rchiodo
Copy link

rchiodo commented Jan 25, 2022

LGTM except for the path based ness of it. Tried on Windows and WSL2

@DonJayamanne DonJayamanne removed their assignment Jan 26, 2022
@DonJayamanne DonJayamanne added the verified Verification succeeded label Jan 26, 2022
@DonJayamanne
Copy link

Tested on WSL2

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants