Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'sysVersion' field from environment type #14034

Closed
karrtikr opened this issue Sep 22, 2020 · 1 comment
Closed

Remove 'sysVersion' field from environment type #14034

karrtikr opened this issue Sep 22, 2020 · 1 comment
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@karrtikr
Copy link

karrtikr commented Sep 22, 2020 •
edited
Loading

There was a bug since 3 years ago related to the sysVersion property on interpreter type, and it was never caught #13997 (comment). Which is when we realized this field is never used, so we can get rid of it.

cc @DonJayamanne @ericsnowcurrently
@karrtikr karrtikr added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team labels Sep 22, 2020
@karrtikr karrtikr changed the title Remove 'sysVersion' field from interpreter Remove 'sysVersion' field from environment type Sep 22, 2020
@karrtikr karrtikr added area-environments Features relating to handling interpreter environments needs PR labels Sep 22, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 22, 2020
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@karrtikr
Copy link
Author

Closing in favor of #20240.

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-environments Features relating to handling interpreter environments debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karrtikr