Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI tests on VSTS for PRs from core contributors of extension #1302

Closed
DonJayamanne opened this issue Apr 5, 2018 · 2 comments
Closed

Run CI tests on VSTS for PRs from core contributors of extension #1302

DonJayamanne opened this issue Apr 5, 2018 · 2 comments
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

The core contributors of the extension have to wait for the tests to pass before we can merge the tests (sometimes the tests take forever, sometimes they need to be re-run - due to flaky tests).
All of this slows down the time taken to merge a PR.

Solution:

  • Run tests on VSTS (all platforms)
  • Once tests pass, merge the PR
  • If tests fail on Master (AppVeyor or Travis), then
    • Restart tests
    • Worst case, identify the problem (identify why tests pass on VSTS and not on AppVeyor/Travis)
  • No changes to external contributors

@brettcannon @MikhailArkhipov
Thoughts
@DonJayamanne DonJayamanne added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. feature-extension labels Apr 5, 2018
@DonJayamanne DonJayamanne added this to the April 2018 milestone Apr 5, 2018
@DonJayamanne DonJayamanne self-assigned this Apr 5, 2018
@DonJayamanne DonJayamanne changed the title Run CI tests on VSTS for core contributors of extension Run CI tests on VSTS for PRs from core contributors of extension Apr 5, 2018
@brettcannon
Copy link
Member

We should set up VSTS to get the 3-platform coverage anyway.

@DonJayamanne DonJayamanne modified the milestones: April 2018, June 2018 Apr 17, 2018
@DonJayamanne
Copy link
Author

Closing as we've commenced work on this, and tracked in a separate issue.

@brettcannon brettcannon removed this from the June 2018 milestone Jun 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @DonJayamanne