Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-standard shells #11473

Closed
kfardanesh opened this issue Apr 28, 2020 · 2 comments
Closed

Support for non-standard shells #11473

kfardanesh opened this issue Apr 28, 2020 · 2 comments
Labels
area-terminal feature-request Request for new features or functionality

Comments

@kfardanesh
Copy link

Running code using the "Run Python File in Terminal" icon should support shells outside of pwsh, cmd, etc. If using Powershell, the command is prefixed with &. If using CMD, the command is not prefixed. If using another shell (such as nushell), the command is still prefixed as if it was powershell. This causes the command to fail.
image

I have been using the setting "terminal.integrated.shell.windows" for setting the shell to utilize.

@kfardanesh kfardanesh added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Apr 28, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Apr 29, 2020
@karthiknadig
Copy link
Member

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

@luabud
Copy link
Member

luabud commented Jun 11, 2020

Hey @kfardanesh! If we were to do it, I believe we'd address #11812 so that it's possible to configure the shell for running Python files. So I'm closing in favour of that 😊

@luabud luabud closed this as completed Jun 11, 2020
@ghost ghost removed the needs decision label Jun 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants