From ef16727d0b26238b8606bab3e821720f159bcdda Mon Sep 17 00:00:00 2001
From: Anthony Kim <62267334+anthonykim1@users.noreply.github.com>
Date: Wed, 2 Aug 2023 13:36:26 -0700
Subject: [PATCH] Clean up smoke test requirement (#21729)

Cleaning up smoke test dependency: See if all Github action test pass
with removing the smoke test requirement file content.

Checked one by one, and came to see removing all doesn't seem to have
impact on the outcome of running smoke test.(Seems to have no difference
in smoke test result outcome when ran with "Run and Debug" in VS Code
with smoke-test option selected).

Also got rid of below, after checking smoke test correctly passing after
removal of smoke-test-requirement.txt content:
![Screenshot 2023-08-01 at 2 57 45
PM](https://github.com/microsoft/vscode-python/assets/62267334/45d404de-74dd-45a5-885b-71a25ef16ad7)

Resolve: #21496
---
 .github/actions/smoke-tests/action.yml | 6 ------
 build/smoke-test-requirements.txt      | 6 ------
 scripts/onCreateCommand.sh             | 1 -
 3 files changed, 13 deletions(-)
 delete mode 100644 build/smoke-test-requirements.txt

diff --git a/.github/actions/smoke-tests/action.yml b/.github/actions/smoke-tests/action.yml
index 9ad6e87cdd26..b2d002050433 100644
--- a/.github/actions/smoke-tests/action.yml
+++ b/.github/actions/smoke-tests/action.yml
@@ -26,7 +26,6 @@ runs:
         cache-dependency-path: |
           build/test-requirements.txt
           requirements.txt
-          build/smoke-test-requirements.txt
 
     - name: Install dependencies (npm ci)
       run: npm ci --prefer-offline
@@ -43,11 +42,6 @@ runs:
         python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --implementation py --no-deps --upgrade --pre debugpy
       shell: bash
 
-    - name: pip install smoke test requirements
-      run: |
-        python -m pip install --upgrade -r build/smoke-test-requirements.txt
-      shell: bash
-
     # Bits from the VSIX are reused by smokeTest.ts to speed things up.
     - name: Download VSIX
       uses: actions/download-artifact@v2
diff --git a/build/smoke-test-requirements.txt b/build/smoke-test-requirements.txt
deleted file mode 100644
index 7d5ac3da00d9..000000000000
--- a/build/smoke-test-requirements.txt
+++ /dev/null
@@ -1,6 +0,0 @@
-# List of requirements for smoke tests (they will attempt to run a kernel)
-jupyter
-numpy
-matplotlib
-pandas
-livelossplot
\ No newline at end of file
diff --git a/scripts/onCreateCommand.sh b/scripts/onCreateCommand.sh
index e93c74f610b9..a90a5366417d 100644
--- a/scripts/onCreateCommand.sh
+++ b/scripts/onCreateCommand.sh
@@ -29,7 +29,6 @@ source /workspaces/vscode-python/.venv/bin/activate
 npx gulp installPythonLibs
 
 /workspaces/vscode-python/.venv/bin/python -m pip install -r build/test-requirements.txt
-/workspaces/vscode-python/.venv/bin/python -m pip install -r build/smoke-test-requirements.txt
 /workspaces/vscode-python/.venv/bin/python -m pip install -r build/functional-test-requirements.txt
 
 # Below will crash codespace