From d30269b95d05e9e2233dc3c4eb4a15c2e3f0091a Mon Sep 17 00:00:00 2001 From: Kartik Raj Date: Fri, 15 Feb 2019 08:53:55 -0800 Subject: [PATCH] Revert pipenv activation to not use `pipenv shell` (#4406) * reverted * news entry * CI coorected --- news/2 Fixes/4394.md | 1 + .../environmentActivationProviders/pipEnvActivationProvider.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 news/2 Fixes/4394.md diff --git a/news/2 Fixes/4394.md b/news/2 Fixes/4394.md new file mode 100644 index 000000000000..92de07bb8bfb --- /dev/null +++ b/news/2 Fixes/4394.md @@ -0,0 +1 @@ +Revert pipenv activation to not use `pipenv shell` diff --git a/src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts b/src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts index b1a03861140f..2a25c7bc1e48 100644 --- a/src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts +++ b/src/client/common/terminal/environmentActivationProviders/pipEnvActivationProvider.ts @@ -5,6 +5,7 @@ import { inject, injectable } from 'inversify'; import { Uri } from 'vscode'; +import '../../../common/extensions'; import { IInterpreterService, InterpreterType, IPipEnvService } from '../../../interpreter/contracts'; import { IWorkspaceService } from '../../application/types'; import { IFileSystem } from '../../platform/types'; @@ -20,7 +21,7 @@ export class PipEnvActivationCommandProvider implements ITerminalActivationComma ) { } public isShellSupported(_targetShell: TerminalShellType): boolean { - return true; + return false; } public async getActivationCommands(resource: Uri | undefined, _: TerminalShellType): Promise {