Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update results display to use VS Code web view API #1109

Closed
MattIrv opened this issue Jun 13, 2018 · 0 comments
Closed

Update results display to use VS Code web view API #1109

MattIrv opened this issue Jun 13, 2018 · 0 comments
Assignees

Comments

@MattIrv
Copy link
Contributor

MattIrv commented Jun 13, 2018

VS Code now exposes a web view API that we can use for the results grid, including an option to persist the web view when it's not active, which will fix issues like #916

I have some code for this ready to go in the feature/useWebviewApi branch, but it needs a bit more testing. Right now it opens results in a new web view every time you execute the query, even if a result tab for that query is already open. Also the "Started executing query at Line _" link doesn't work correctly if the results and query are in different editor columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant