"No link definition found" for footnotes

[dtinth]

When I use footnotes¹, the language server generates a warning.

Here’s a repro, put this is src/test/diagnostic.test.ts:

	test('Should not generate diagnostic for valid footnotes', withStore(async (store) => {
		const doc = new InMemoryDocument(workspacePath('doc.test.md'), joinLines(
			`footnotes should work[^fn1]`,
			``,
			`[^fn1]: this is a footnote`,
		));

		const workspace = store.add(new InMemoryWorkspace([doc]));

		const diagnostics = await getComputedDiagnostics(store, doc, workspace);
		assertDiagnosticsEqual(diagnostics, []);
	}));

Footnotes

1. https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/ ↩

[mjbvz]

Footnotes aren't part of CommonMark so this is expected

They are common enough that I'd be open to adding support for them, but that should be something the library consumer has to opt into

[hellt]

I second that, footnotes are awesome and it'd be great for vscode markdown services to parse them accordingly