-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve experience when using Codespaces #111
Comments
Bump. The current workaround I've found is to open the preview tab (causes error), then use the context menu to open the preview in a separate tab (which actually works), then go back to Codespaces, close the preview tab, and re-open it using the right-click drop-down menu on the relevant document. Being able to boot up a preview without having to jump through that many hoops would be great. |
77 tasks
92 tasks
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, as mentioned in #58, the embedded preview will not immediately work in Codespaces upon first launching (or sometimes just upon forwarding a port). This is because the content at the local address is not actually available until the user goes through some redirects in their browser. Since one of these redirects is github.com and github can't be framed in an iframe, it shows an error.
There isn't a way to see whether this failure happened from the extension side, so it's difficult to implement some type of fix upon failure.
Without help from the GitHub side in regards to detecting whether these redirects have happened and no way to perform the redirects programmatically, we could probably do something like:
open external preview
command immediately. There should be a "don't show again" on this and perhaps some info on how to fix the issue yourself. However, I'm not too sure if there's currently an API to show a warning message, asPortAttributes
does not seem to support this.In the most ideal case, we would have a way to programmatically trigger the redirects, although they are most likely there for a reason (security, cookies).
The text was updated successfully, but these errors were encountered: