Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API documentation for MessageReader #633

Closed
AArnott opened this issue Jun 10, 2020 · 2 comments · Fixed by #636
Closed

Add API documentation for MessageReader #633

AArnott opened this issue Jun 10, 2020 · 2 comments · Fixed by #636

Comments

@AArnott
Copy link
Member

AArnott commented Jun 10, 2020

I'm implementing my own MessageReader and MessageWriter. The MessageReader.onPartialMessage isn't documented and I'm having a difficult time figuring out what it's for. I may have to go digging into the source code to figure it out.
Can API docs be added?
@AArnott AArnott mentioned this issue Jun 10, 2020
Merged
@dbaeumer
Copy link
Member

Yes, of course. If I recall it correctly I added this a long time ago based on your suggestion. If signals the fact the a message after some timeout did not fully make it to the receiver.

@AArnott
Copy link
Member Author

AArnott commented Jun 11, 2020

Funny. I don't remember making that suggestion, but thanks for taking the PR.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document MessageReader/MessageWriter interfaces AArnott/vscode-languageserver-node
2 participants
@AArnott @dbaeumer