Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextDocument.getText() should accept Range as an optional parameter #255

Closed
ThisIsManta opened this issue Sep 28, 2017 · 2 comments · Fixed by #298
Closed

TextDocument.getText() should accept Range as an optional parameter #255

ThisIsManta opened this issue Sep 28, 2017 · 2 comments · Fixed by #298

Comments

@ThisIsManta
Copy link

TextDocument.getText method should accept Range as an optional parameter. This refers to https://code.visualstudio.com/docs/extensionAPI/vscode-api#_a-nametextdocumentaspan-classcodeitem-id38textdocumentspan
@dbaeumer dbaeumer added this to the Backlog milestone Oct 2, 2017
@rcjsuen
Copy link
Contributor

rcjsuen commented Oct 6, 2017

What should/will happen if the provided Range is invalid?

@dcastro
Copy link

dcastro commented Dec 18, 2017

@rcjsuen I'd say : string | undefined

@rcjsuen rcjsuen mentioned this issue Dec 25, 2017
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 24, 2018
@dbaeumer dbaeumer removed this from the Backlog milestone Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change TextDocument's getText to take an optional range rcjsuen/vscode-languageserver-node
4 participants
@dcastro @dbaeumer @ThisIsManta @rcjsuen