Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the finished timestamp when cell finish running #9508

Closed
rchiodo opened this issue Mar 28, 2022 Discussed in #9498 · 4 comments
Closed

Show the finished timestamp when cell finish running #9508

rchiodo opened this issue Mar 28, 2022 Discussed in #9498 · 4 comments

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Mar 28, 2022

Discussed in #9498

Originally posted by amssljc March 26, 2022

@andreaschiappacasse
Copy link

andreaschiappacasse commented Mar 28, 2022

+1 on this issue, maybe i'd prefer to be able to see the "start time" instead of the "finish time", so that it could be added to running cells as well (even if it's trivial to get the start time in that case from the ongoing duration).

e.g. something like:
image

I see that it was originally discussed in #1454, when a timestamp was mentioned along with the total duration, I presume it was discarded to avoid adding too much text below the cell, maybe this could be enabled via settings and disabled by default?

@rchiodo
Copy link
Contributor Author

rchiodo commented Mar 28, 2022

@andreaschiappacasse Would you want this start time/finish time always displayed, even when opening the notebook somewhere else?

Meaning the finish time would be saved in the notebook metadata?

@andreaschiappacasse
Copy link

andreaschiappacasse commented Mar 29, 2022

@andreaschiappacasse Would you want this start time/finish time always displayed, even when opening the notebook somewhere else?

Meaning the finish time would be saved in the notebook metadata?

Given that the execution time is not currently stored in the notebook, I wouldn't expect this kind of information to be stored either (and it's not needed in my daily use), but I do think it would be a nice feature.
It could be usefuI in some cases to be able to see when a notebook was run last and how long it took.

In that case, it could be nice to be compliant to what this extension does, as in saving it as:

{
    "ExecuteTime": {
        "start_time": "2016-02-11T18:51:18.536796",
        "end_time": "2016-02-11T18:51:35.806119"
    }
}

So that opening the notebook in jupyter (with that extension enabled) could recover the timings.


On the other hand, if persistence is really needed in one's use case, it is easy to add some timing functionality to the cells output. So I would be equally happy with a solution mimicking the current "execution time" implementation.


To build on the idea, UI wise, another, maybe cleaner (?), solution, could be having the starting or/and finishing time to be displayed on mouse over on the execution time. In this way, the current UI would stay untouched but timings could be easily recovered as well.

@DonJayamanne
Copy link
Contributor

Closing as a duplicate of microsoft/vscode#168792

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants