Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot stop editing markdown cell by using hot key #7042

Closed
christina-0725 opened this issue Aug 10, 2021 · 3 comments
Closed

Cannot stop editing markdown cell by using hot key #7042

christina-0725 opened this issue Aug 10, 2021 · 3 comments
Assignees
Labels
notebook-workflow Issues that interrupt expected or desirable behavior

Comments

@christina-0725
Copy link

Issue Type: Feature Request

Description

I have changed run cell (ID: "notebook.cell.execute") hot key to ctrl+enter, which is same as stop editing cell (ID: "notebook.cell.quitEdit"). After changing, when I press ctrl+enter. I cannot stop editing and preview markdown cell.

Suggestion

I hope I can stop editing and preview markdown cell when I press ctrl+enter even if these two hot keys are the same. Thank you!

Other

The ui of new version jupyter is so cool, I love it.
But when I preview the markdown cell, the font size is so small that I cannot see the words clearly, how can I change the font size of markdown cell preview text.

Extension version: 2021.8.1195043623
VS Code version: Code 1.59.0 (379476f0e13988d90fab105c5c19e7abc8b1dea8, 2021-08-04T23:13:12.822Z)
OS version: Windows_NT x64 10.0.18363
Restricted Mode: No

@IanMatthewHuff
Copy link
Member

Hmm, I'm not fully sure if we can resolve that hotkey issue. If both actions are mapping to the same hotkey one of them is going to win out and be applied over the other, not both. One thing to try if you want to apply notebook.cell.execute only to non-markdown cells you could add a notebookCellType != 'markup' clause to the new keybinding you added for ctrl+enter. That should apply that only to non-markup cells, leaving markup cells to fall back to the old quitEdit command. Does that help at all?

Also regarding the font size, we have an issue open here for that, feel free to upvote (that would bump it up the priority list):
microsoft/vscode#126294

@IanMatthewHuff IanMatthewHuff added the notebook-workflow Issues that interrupt expected or desirable behavior label Aug 10, 2021
@christina-0725
Copy link
Author

Thank you for your answer, it really helps me a lot.

And I upvoted at the issue, the preview image is as follows, the font size of markdown preview text is too small.
preview

@greazer
Copy link
Member

greazer commented Aug 12, 2021

@christina-0725, looks like all of the problems you've suggested are resolved for now. Please reopen if there's anything still remaining.

@greazer greazer closed this as completed Aug 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-workflow Issues that interrupt expected or desirable behavior
Projects
None yet
Development

No branches or pull requests

3 participants