Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Insiders cannot open notebooks #4796

Closed
rchiodo opened this issue Feb 12, 2021 · 38 comments
Closed

VS Code Insiders cannot open notebooks #4796

rchiodo opened this issue Feb 12, 2021 · 38 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Feb 12, 2021

Notebooks broken in insiders

Since this version:

image

VS code insiders is making breaking changes to the proposed API the jupyter extension uses to open notebooks. Until we can get a new build out, we recommend going back to stable.

This issue will track our progress on making a new build just for insiders.

You can also go back to an older build of insiders if you want to continue using it. See directions here on how to do that:
microsoft/vscode#46089 (comment)

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Feb 12, 2021
@rchiodo rchiodo pinned this issue Feb 12, 2021
@peterschmidt85

This comment has been minimized.

@ShuhuaGao
Copy link

Same issue #4806

@ShuhuaGao
Copy link

After the latest update of VS Code Insiders, the error message becomes "Unable to open 'IL_BC.ipynb': Cannot read property 'Markdown' of undefined.".

Version: 1.54.0-insider (user setup)
Commit: a699ffaee62010c4634d301da2bbdb7646b8d1da
Date: 2021-02-15T05:17:48.792Z
Electron: 11.2.3
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.18362

@furkantektas
Copy link

Same issue here:
Unable to open 'XXX.ipynb': Cannot read property 'Code' of undefined.

Version: 1.54.0-insider
Commit: a699ffaee62010c4634d301da2bbdb7646b8d1da
Date: 2021-02-15T05:15:52.209Z (5 hrs ago)
Electron: 11.2.3
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 20.3.0

Jupyter versions (conda):

jupyter_client            6.1.11             pyhd8ed1ab_1    conda-forge
jupyter_core              4.7.1            py37hf985489_0    conda-forge
jupyter_server            1.3.0            py37hf985489_0    conda-forge
jupyterlab                3.0.7              pyhd8ed1ab_0    conda-forge
jupyterlab_code_formatter 1.4.4              pyhd8ed1ab_0    conda-forge
jupyterlab_execute_time   2.0.1              pyhd8ed1ab_1    conda-forge
jupyterlab_pygments       0.1.2              pyh9f0ad1d_0    conda-forge
jupyterlab_server         2.2.0              pyhd8ed1ab_0    conda-forge
jupyterlab_widgets        1.0.0              pyhd8ed1ab_1    conda-forge

@ShuhuaGao
Copy link

You can also go back to an older build of insiders

The previous Insider version 1.53.0 works, which can be downloaded from https://vscode-update.azurewebsites.net/1.53.0-insider/win32-x64/insider (for Windows).

In settings, search "update: Mode" and set it to "manual" to disallow automatic update. Different versions of VS code can co-exist but you need to start the specific version by double-clicking Code - Insiders.exe in the specific folder.

@codekitchen
Copy link

For Apple Silicon Macs, the link you want is https://vscode-update.azurewebsites.net/1.53.0-insider/darwin-arm64/insider (it took me a few minutes to figure that out, so maybe that'll help others)

@rohan-paul
Copy link

For Linux (Ubuntu 20.04), got the .deb file for 1.53.0 from here.

vscode-update.azurewebsites.net/1.53.0-insider/linux-deb-x64/insider

@ayim

This comment has been minimized.

@frenkcleven
Copy link

For completeness: 1.53.0 Insider build for Intel Macs.

@taisbak
Copy link

taisbak commented Feb 18, 2021

You need to add -user to the download url if vscode is installed without local admin rights using user set-up, e.g.:
https://vscode-update.azurewebsites.net/1.53.0-insider/win32-x64-user/insider

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Feb 18, 2021

Just an update, we are looking into this, and aware of the issues.
The Insiders Notebook API has changed significantly and are in the process of updating the code accordingly.
& I'm sorry for the inconvenience

@rednag
Copy link

rednag commented Feb 20, 2021

Same issue here:
Unable to open 'XXX.ipynb': Cannot read property 'Code' of undefined.

Version: 1.54.0-insider
Commit: a699ffaee62010c4634d301da2bbdb7646b8d1da
Date: 2021-02-15T05:15:52.209Z (5 hrs ago)
Electron: 11.2.3
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 20.3.0

Jupyter versions (conda):

jupyter_client            6.1.11             pyhd8ed1ab_1    conda-forge
jupyter_core              4.7.1            py37hf985489_0    conda-forge
jupyter_server            1.3.0            py37hf985489_0    conda-forge
jupyterlab                3.0.7              pyhd8ed1ab_0    conda-forge
jupyterlab_code_formatter 1.4.4              pyhd8ed1ab_0    conda-forge
jupyterlab_execute_time   2.0.1              pyhd8ed1ab_1    conda-forge
jupyterlab_pygments       0.1.2              pyh9f0ad1d_0    conda-forge
jupyterlab_server         2.2.0              pyhd8ed1ab_0    conda-forge
jupyterlab_widgets        1.0.0              pyhd8ed1ab_1    conda-forge

Same issue - for now I'm working with the normal VSCode where notebooks are running.

@DonJayamanne
Copy link
Contributor

A new extension has been published to the marketplace with the fixes.
Please ensure you update to the latest version of VS Code insiders & the latest version of the Python extension 2021.3.xxxx

@DonJayamanne
Copy link
Contributor

Moving to validate

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 23, 2021

For me I had to update the juypter extension and reload VS code for this to work with VS code insiders.

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 23, 2021

Nope sorry still not working. See this issue:
microsoft/vscode#117445

It works partially now. If you use the 'Open With' editor you can open a notebook in insiders again:

image

@DonJayamanne DonJayamanne added upstream-vscode Blocked on upstream VS code vscode-notebook labels Feb 23, 2021
@frenkcleven
Copy link

Nope sorry still not working. See this issue:
microsoft/vscode#117445

It works partially now. If you use the 'Open With' editor you can open a notebook in insiders again:

image

Same for me. But at least this is usable for now. Thanks!

@AndrewLaganaro
Copy link

Returned to 1.53.0 version on windows 10, also rolled back the jupyter extension which has also previously been updated and eveything got to work back again. Also turned off Vscode auto update and python auto update too for a while.

@gusbemacbe
Copy link

gusbemacbe commented Feb 23, 2021

After updating the Python extension and reinstaling the @DonJayamanne's VSIX extension, the Jupyter notebooks work here on VSCode 1.54 now, but I receive two errors from Python extension:

imagem

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 23, 2021

Sorry but you also need the insiders version of the python extension. It has similar problems with the API.

You can do this automatically with this setting here:

image

@gusbemacbe
Copy link

Sorry but you also need the insiders version of the python extension. It has similar problems with the API.

You can do this automatically with this setting here:

image

It worked now, thank you!

Too bad that VSCode Insiders with Jupyter Notebook (even if I always trusted the notebooks) does not support Jupyter Notebook's Python Markdown extension.

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 23, 2021

Too bad that VSCode Insiders with Jupyter Notebook (even if I always trusted the notebooks) does not support Jupyter Notebook's Python Markdown extension.

@gusbemacbe Do you want to log a suggestion for this?

@gusbemacbe
Copy link

Too bad that VSCode Insiders with Jupyter Notebook (even if I always trusted the notebooks) does not support Jupyter Notebook's Python Markdown extension.

@gusbemacbe Do you want to log a suggestion for this?

Yes, I refer to the https://jupyter-contrib-nbextensions.readthedocs.io/en/latest/nbextensions/python-markdown/readme.html.

@virtu
Copy link

virtu commented Feb 24, 2021

After upgrading, notebooks are no longer detected but displayed as plain text in VSCode insiders. Any suggestions?

@jeanga
Copy link

jeanga commented Feb 24, 2021

Right click & "open with" did the job for me.

@virtu
Copy link

virtu commented Feb 24, 2021

Right click & "open with" did the job for me.

Thanks! Should be fixed, though, so the regular approach works again.

@eduardopaul
Copy link

Working like a charm! Thanks all for the amazing extension. Do you have any idea when this new notebook interface should be released in VSCode's regular version?

@taisbak
Copy link

taisbak commented Feb 24, 2021

Working like a charm! Thanks all for the amazing extension. Do you have any idea when this new notebook interface should be released in VSCode's regular version?

Yes it does! Thank you.

@marcbernot
Copy link

Thanks notebooks work in 1.54. Is the live sharing of notebooks supposed to work? I never managed to get it working. Tips would be appreciated

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 24, 2021

Thanks notebooks work in 1.54. Is the live sharing of notebooks supposed to work? I never managed to get it working. Tips would be appreciated

Live share of notebooks is a work in progress. You can track that here I believe:
microsoft/live-share#3301
https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/notebooks

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 24, 2021

I'm closing this bug as the latest VS code insiders and the latest Jupyter extension and latest python insiders extension all seem to be working.

Going forward we hope to be able to ship the jupyter extension more often to deal with breaking issues from VS code on a much quicker cadence.

Thanks for your patience.

@rchiodo rchiodo closed this as completed Feb 24, 2021
@rchiodo rchiodo unpinned this issue Feb 24, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 24, 2021

Do you have any idea when this new notebook interface should be released in VSCode's regular version?

@eduardopaul this is actively being pursued. We're working on testing it with a few customers first to see how the new version compares to the old one. Right now your best bet for using the new interface is to use the insiders version.

@gusbemacbe
Copy link

@rchiodo, and Jupyter Notebook's Python Markdown extension?

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 24, 2021

@gusbemacbe I suggest you log a new issue for the markdown extension. Until that happens we won't be able to tell how many other people want it. Meaning right now it's not planned at all.

@microsoft microsoft locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code
Projects
None yet
Development

No branches or pull requests