Determine how to ship Jupyter Keybindings for Native Notebooks

[linette-zyy]

Environment data

Steps to reproduce

1. Run cell and export as Jupyter notebook named 'tester.ipynb' in interactive window.
2. Open tester.ipynb in editor
3. Hit o on a code cell with output and verify that outputs disappear.
4. Hit z and verify a deleted cell reappears
5. Hit l on a code cell and verify line numbers appear

Expected behaviour

Hit o on a code cell with output and verify that outputs disappear.
Hit z and verify a deleted cell reappears
Hit l on a code cell and verify line numbers appear

Actual behaviour

Hit o on a code cell with output and that outputs did not disappear.
Hit z and a deleted cell did not reappear
Hit l with no line numbers appear

[linette-zyy]

This issue is not reproduce on stable build.

[IanMatthewHuff]

Thanks. Some of these might just be differences with the new notebook UI on insiders. Will look into it.

[greazer]

We need to make sure that if we solve this in the jupyter extension we don't cause problems for users who customize keyboard shortcuts in general.

[DonJayamanne]

Suggestion from VS Code microsoft/vscode#106679

[DonJayamanne]

Solution as proposed by VS Code

Option 1 (preferred by VS Code): Create a new extension to ship keybindings

• New extension will be dependency of Jupyter extension
• Category should not contain keymap (see previous comment in VS Code repo for details)
• All key bindings should go into this
• This way, if users don't want default Jupyter key bindings, they can disable this new extension & (optionally install another extension if someone creates it).
• Also easy for users to discover & disable this key bindings (if they don't want jupyter key bindings)
  Problem: Unfortunately VS Code doesn't support disabling of dependant extensions (I have pass this info to VS Code).

Option 2: Add all key bindings in the Juypyter extension with when clause to disable it

• In the when clause make a reference to a config setting (we alraedy do this today()
• If that setting is set, then such key bindings will not be enabled.
• This allows users to disable jupyter style keybindings.
• Not VSCodes preferred option (as key bindings are generally separate extensions).

Right now Option 1 does not work, hence we will need to go with Option 2

[DonJayamanne]

We decided to go with option 2.
Details can be found here https://teams.microsoft.com/l/message/19:9b163ad1e1ed4c49938d9692be1ce751@thread.skype/1610576559108?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=6182cd1a-acf2-40e6-8b08-07bd25990df8&parentMessageId=1610576559108&teamName=Python%20for%20VS%20Code&channelName=Data%20Science&createdTime=1610576559108

[DonJayamanne]

Shortcuts to be added are in #4376

[DonJayamanne]

Closing this issue as we have a solution & the issue is tracked in #4376