Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Module not found" errors in prePublishBundle step but CI not failing #2124

Closed
kimadeline opened this issue Mar 24, 2020 · 1 comment
Closed

"Module not found" errors in prePublishBundle step but CI not failing #2124

kimadeline opened this issue Mar 24, 2020 · 1 comment

Comments

@kimadeline
Copy link
Contributor

Why is CI not failing:

https://dev.azure.com/ms/vscode-python/_build/results?buildId=69595&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=3f6c1bb4-e2b1-5180-b7f3-9a06f477b8ee

image

netlify/netlify-lambda#179 mentions exporting webpack-node-externals in the webpack config, which we don't do (it is on our dependencies though).
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 25, 2020 •
edited
Loading

Why is CI not failing:

Because these are warnings and not errors, also VSIX has been built successfully, hence Build was successful.

We have code to ensure we know what warnings are displayed. If new warnings are displayed then the Build fails. Also the VSIX has been built. So nothing to do here.

Screen Shot 2020-03-25 at 09 43 00

@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @kimadeline