Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to use resolveEnvironment for the selected Python kernel to get version information #15254

Closed
karrtikr opened this issue Feb 27, 2024 · 3 comments
Closed

Make sure to use resolveEnvironment for the selected Python kernel to get version information #15254

karrtikr opened this issue Feb 27, 2024 · 3 comments
Assignees
@DonJayamanne
Labels
debt Code quality issues
Milestone
March 2024

Comments

@karrtikr
Copy link
Contributor

Opening based on microsoft/vscode-python#22877 (comment). It seems that currently if the details are available in environments.known, we use that, else we get it from resolveEnvironment.

Related: #15140
@karrtikr karrtikr added the feature-request Request for new features or functionality label Feb 27, 2024
@DonJayamanne
Copy link
Contributor

We are already doing this

@DonJayamanne DonJayamanne removed the feature-request Request for new features or functionality label Feb 27, 2024
@DonJayamanne
Copy link
Contributor

@karrtikr Found that there could be a race condition here, will look at modifying the code to always call resolve when getting the version.

@karrtikr karrtikr reopened this Feb 28, 2024
@DonJayamanne DonJayamanne self-assigned this Feb 28, 2024
@DonJayamanne DonJayamanne added the debt Code quality issues label Feb 28, 2024
@DonJayamanne DonJayamanne added this to the March 2024 milestone Feb 28, 2024
@DonJayamanne
Copy link
Contributor

Done #15261

@karrtikr karrtikr mentioned this issue Feb 29, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2024
Development

No branches or pull requests
2 participants
@DonJayamanne @karrtikr