Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore supporting Comms messaging on code execution #15124

Closed
2 tasks done
DonJayamanne opened this issue Feb 4, 2024 · 3 comments
Closed
2 tasks done

Explore supporting Comms messaging on code execution #15124

DonJayamanne opened this issue Feb 4, 2024 · 3 comments
Assignees
@DonJayamanne
Labels
notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) *out-of-scope Posted issue is not in scope of VS Code partner
Milestone
March 2024

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Feb 4, 2024 •
edited
Loading

Current proposal

  • Ensure Comms API only works within the context of a pending request execution
    • I.e. 3rd party makes a request to execute code via the kernel API
    • & comms is valid only until this execution request has not resolved
    • Once execution completes, the comms API will not be available.

Tasks
Preview Give feedback
  1. Reconstruct all comms after querying kernel #14468
    debt ipywidgets
    DonJayamanne
  2. Unable to regsiter comm target in extension host #14776
    bug debt partner
    DonJayamanne
@DonJayamanne DonJayamanne added notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) feature-request Request for new features or functionality labels Feb 4, 2024
@DonJayamanne DonJayamanne self-assigned this Feb 4, 2024
@DonJayamanne DonJayamanne mentioned this issue Feb 4, 2024
Closed
@DonJayamanne DonJayamanne added this to the February 2024 milestone Feb 4, 2024
@kieferrm kieferrm mentioned this issue Feb 5, 2024
Closed
61 tasks
This was referenced Feb 6, 2024
Closed
Merged
@DonJayamanne DonJayamanne modified the milestones: March 2024, April 2024 Mar 26, 2024
@DonJayamanne
Copy link
Contributor Author

@rebornix I am closing this issue as completed.
As we do not need this.

@rebornix
Copy link
Member

Sounds reasonable to me.

@DonJayamanne DonJayamanne added *out-of-scope Posted issue is not in scope of VS Code and removed feature-request Request for new features or functionality labels Mar 26, 2024
@DonJayamanne
Copy link
Contributor Author

Closing in favour of #15437

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) *out-of-scope Posted issue is not in scope of VS Code partner
Projects
None yet
Milestone
March 2024
Development

No branches or pull requests
2 participants
@rebornix @DonJayamanne