Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker item polish #42

Open
2 of 3 tasks
joyceerhl opened this issue Sep 26, 2023 · 2 comments
Open
2 of 3 tasks

Picker item polish #42

joyceerhl opened this issue Sep 26, 2023 · 2 comments
Assignees

Comments

@joyceerhl
Copy link

joyceerhl commented Sep 26, 2023

Testing microsoft/vscode-jupyter#14367

  1. Enter the URL of the running JupyterHub Server... could be shortened to Enter URL of running JupyterHub server in the quickpick item name and placeholder
  2. Invalid JupyterHub URL is pretty vague and hard to troubleshoot (could be because there isn't a server at that URL, or because of some other connectivity error), would be nice to either include the actual error message or provide a command link to open the extension output channel for logs
    Image
  3. If the username and password are wrong we show the username input again and say Invalid username or password., there shouldn't be a period at the end of that as it's inconsistent with the other validation messages that we show, and ideally it should say something more actionable like Your username or password did not match (even better if we can say which part was incorrect)
@DonJayamanne
Copy link
Collaborator

even better if we can say which part was incorrect)

As a best practice in security this is never done, else anyone trying to hack your account know they have made progress and need to only focus on the other

error message or provide a command link to open the extension output channel for logs

To my knowledge cors errors cannot be detected,

@DonJayamanne
Copy link
Collaborator

could be shortened to Enter URL of running JupyterHub server in the quickpick item name and placeholder

Leaving this as is, as this is what we have in the Jupyter extension for standard urls.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants