Allow to use self hosted gitlab registry.

[uhlhosting]

Issue Type: Feature Request

I see that there is a feature to add registries in docker from several places like azure, gitlab, i would like to setup hosted gitlab is this possible, will be in future?

Extension version: 1.0.0
VS Code version: Code - Insiders 1.44.0-insider (ea935488ec0e5415d4205c1f33ba332fd417f85a, 2020-04-07T12:27:31.043Z)
OS version: Darwin x64 19.4.0

[bwateratmsft]

Isn't GitLab single-tenant hosting gone? I misread this page: https://about.gitlab.com/gitlab-hosted/

GitLab's registry provider is not Registry V2 compliant, so I doubt their self-hosted solution has that either. I would suggest requesting that they create a compliant V2 API. At the moment we don't have plans to add support for any non-compliant registry providers.

[bwateratmsft]

I added this request to our list over in #869, so I will close this one as a duplicate of that.

[uhlhosting]

@bwateratmsft according to this, gitlab has v2 support.

As of GitLab 11.9, we began shipping version 2.7.1 of the Docker container registry, which disables the schema1 manifest by default. If you are still using older Docker clients (1.9 or older), you may experience an error pushing images. See omnibus-4145 for more details.

[bwateratmsft]

Can you link that? If GitLab has added V2 support I am definitely going to investigate further.

[uhlhosting]

Sure here you go @bwateratmsft https://docs.gitlab.com/ce/administration/packages/container_registry.html#supporting-older-docker-clients

[bwateratmsft]

Since this registry is based on the common registry image, it may already be possible, or become possible in 1.1 due to some additional work we did on V2 registries.

Can you run command Docker Registries: Connect registry..., choose Generic Docker Registry (Preview) as the provider, provide your registry URL and credentials, and try it out?

In 1.1 we added support for OAuth to registries in some cases, so if the registry requires OAuth it won't yet be possible in 1.0.

[uhlhosting]

seems its not liking it. i wonder why the gitlab.com code cant be tested for self hosted.

[bwateratmsft]

Do you know if your registry requires OAuth or does it allow password auth?

[uhlhosting]

I am not sure on this one. Will try to check. I believe will follow same principle like in gitlab.com maybe you can take a look to see the approach used there, since that one is already supported.

[uhlhosting]

My guess based on this:

is that they do use oauth in order to provision the token support for registry.

[bwateratmsft]

If you want, you could try installing the latest nightly version of the extension: How to install Nightly version of Docker extension

This has the OAuth changes we made for our upcoming 1.1 version of the extension.