Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerminateThreadRequest #150

Closed
roblourens opened this issue Jan 17, 2018 · 1 comment
Closed

TerminateThreadRequest #150

roblourens opened this issue Jan 17, 2018 · 1 comment
Assignees
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Jan 17, 2018

A client should be able to request to terminate a thread. Should include a capability to indicate whether it's supported by the runtime/adapter.

In vscode, this would probably just be a context menu option on the thread item of the callstack. An extension could implement this easily by contributing a context menu command and sending a custom debug request. Although the context menu command would show up on every row of the callstack, not just threads: microsoft/vscode#19180

/** TerminateThread request; value of command field is 'terminateThread'.
	The request starts the debuggee to run again.
*/
export interface TerminateThreadRequest extends Request {
	// command: 'terminateThread';
	arguments: TerminateThreadArguments;
}

/** Arguments for 'terminateThread' request. */
export interface TerminateThreadArguments {
	threadId: number;
}

cc
@mostafaeweda
@ebluestein

@weinand weinand self-assigned this Jan 23, 2018
@weinand weinand added this to the On Deck milestone Jan 23, 2018
@weinand weinand modified the milestones: On Deck, March 2018 Mar 13, 2018
@weinand weinand closed this as completed Mar 13, 2018
@weinand
Copy link
Contributor

weinand commented Mar 13, 2018

See 9457a85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants