Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update walkthrough #10707

Merged
merged 21 commits into from
Apr 8, 2023
Merged

Update walkthrough #10707

merged 21 commits into from
Apr 8, 2023

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Mar 20, 2023

Let's use this PR to mark what still needs to happen in this branch to complete the walkthrough.

@sean-mcmanus
Copy link
Collaborator

Is this ready for review or who is working on this?

@AlexandraKemperMS
Copy link

Is this ready for review or who is working on this?

Not yet - we still need to add the functionality listed in this work item: #8304 (comment)
I started updating the code to reference the quickpick and added a ToDo where that needs to be finished. Also, the svgs are not ready.

@bobbrow bobbrow linked an issue Mar 27, 2023 that may be closed by this pull request
C++ Walkthrough improvements #8304
Closed
bobbrow
bobbrow commented Mar 27, 2023
View reviewed changes
Extension/package.json Outdated Show resolved Hide resolved
@bobbrow bobbrow added this to the 1.15 milestone Mar 29, 2023
michelleangela
michelleangela previously approved these changes Apr 7, 2023
View reviewed changes
sean-mcmanus
sean-mcmanus requested changes Apr 7, 2023
View reviewed changes
Extension/package.nls.json Outdated Show resolved Hide resolved
sean-mcmanus
sean-mcmanus previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A made a bunch of capitalization inconsistency comments.

@Colengms Colengms merged commit 0ec40d9 into main Apr 8, 2023
@Colengms Colengms deleted the update-walkthrough branch April 8, 2023 00:35
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Colengms Colengms Colengms left review comments

@AlexandraKemperMS AlexandraKemperMS AlexandraKemperMS left review comments

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@michelleangela michelleangela michelleangela left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

C++ Walkthrough improvements
6 participants
@bobbrow @sean-mcmanus @AlexandraKemperMS @michelleangela @Colengms @jureid