Error messages for create declaration definition #10393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleangela
force-pushed
the
mimatias/refactorerrormsg
branch
from
12ad173
to
b60bf45
Compare
sean-mcmanus
previously approved these changes
Jan 26, 2023
michelleangela
force-pushed
the
mimatias/refactorerrormsg
branch
from
127a88d
to
2f33bf4
Compare
michelleangela
force-pushed
the
mimatias/refactorerrormsg
branch
from
03bcc83
to
8ad3ec3
Compare
sean-mcmanus
requested changes
Feb 4, 2023
| }, | ||
| "e_com_virtual_redundant": { | ||
| "text": "vsCMFunctionVirtual is redundant and must not be specified when with vsCMFunctionComMethod.", | ||
| "hint": "Do not localized 'vsCMFunctionVirtual' and 'vsCMFunctionComMethod', they are code implementation." |
There was a problem hiding this comment.
localized->localize
(multiple spots)
sean-mcmanus
reviewed
Feb 4, 2023
| "refactor_create_declaration_definition_failed": | ||
| { | ||
| "text": "Create Declaration / Definition failed:", | ||
| "hint": "The operation 'Create Declaration / Definition' on a function was not successfully." |
There was a problem hiding this comment.
successfully->successful.
There was a problem hiding this comment.
I just checked-in. I'll fix in next PR. I have other strings to fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error messages for create declaration definition feature.