Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MS extensions should be enabled by default for Cygwin and MinGW #8353

Closed
Colengms opened this issue Nov 1, 2021 · 4 comments
Closed

MS extensions should be enabled by default for Cygwin and MinGW #8353

Colengms opened this issue Nov 1, 2021 · 4 comments
Assignees
@browntarik
Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone
1.15.0

Comments

@Colengms
Copy link
Collaborator

Colengms commented Nov 1, 2021

This is derived from: #6412

Apparently (based on experimentation), Cygwin supports MS Extensions despite not returning the associated define (_MSC_EXTENSIONS).

Opening this issue to track enabling MS Extensions for Cygwin gcc, by default.
@Colengms Colengms added bug Language Service Feature: Configuration An issue related to configuring the extension or IntelliSense labels Nov 1, 2021
@Colengms Colengms added this to the Backlog milestone Nov 1, 2021
@Colengms Colengms mentioned this issue Nov 1, 2021
Closed
@Colengms Colengms modified the milestones: Backlog, 1.8.0 Nov 1, 2021
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Nov 1, 2021
@sean-mcmanus sean-mcmanus modified the milestones: 1.8.0, 1.8.0-insiders Nov 24, 2021
@Colengms Colengms closed this as completed Dec 8, 2021
@Colengms
Copy link
Collaborator Author

Colengms commented Dec 14, 2021 •
edited by sean-mcmanus
Loading

Re-opening and using to track re-enabling of ms_extensions by default for Cygwin and MinGW.

We have some known bugs (internally: 1447675, 1450571, 1450651, 1452900) with ms_extensions on gcc, which we'd like to address before enabling this by default. Users can manually enable it by adding -fms_extensions as a compiler arg.

@Colengms Colengms reopened this Dec 14, 2021
@Colengms Colengms removed the fixed Check the Milestone for the release in which the fix is or will be available. label Dec 14, 2021
@Colengms Colengms modified the milestones: 1.8.0-insiders, On Deck Dec 14, 2021
@Colengms Colengms changed the title MS extensions should be enabled by default for Cygwin MS extensions should be enabled by default for Cygwin and MinGW Dec 14, 2021
@Colengms Colengms mentioned this issue Dec 17, 2021
Closed
@sean-mcmanus sean-mcmanus mentioned this issue Jan 3, 2022
Closed
@sean-mcmanus
Copy link
Collaborator

1450651 has been fixed (pending integration).

This was referenced Jan 19, 2022
Closed
Closed
Closed
Closed
Closed
@sean-mcmanus sean-mcmanus removed this from the On Deck milestone May 18, 2022
@sean-mcmanus sean-mcmanus added this to the 1.10.3 milestone May 18, 2022
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label May 18, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.10.3, On Deck May 18, 2022
@sean-mcmanus sean-mcmanus removed the fixed Check the Milestone for the release in which the fix is or will be available. label May 18, 2022
@Colengms
Copy link
Collaborator Author

It looks like the remaining two issues blocking this have been fixed. Maybe we can enable MS extensions for Cygwin and MinGW by default now?

@sean-mcmanus
Copy link
Collaborator

Sure, we could try that for 1.15.

@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.15.0 Mar 6, 2023
@browntarik browntarik added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@browntarik browntarik

Labels
bug Feature: Configuration An issue related to configuring the extension or IntelliSense fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
4 participants
@sean-mcmanus @Colengms @browntarik @Bernardin-MS