Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't show documentation for typedef in a namespace #5241

Closed
ShukantPal opened this issue Apr 2, 2020 · 9 comments
Closed

Doesn't show documentation for typedef in a namespace #5241

ShukantPal opened this issue Apr 2, 2020 · 9 comments
Labels
bug Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone

Comments

@ShukantPal
Copy link

ShukantPal commented Apr 2, 2020

Type: LanguageService

/**
 * Summary
 */
typedef uint64_t Move;

constexpr Move move;

Hovering over Move doesn't show the documentation like moving over a method or class does.

@sean-mcmanus sean-mcmanus added Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. Language Service more info needed The issue report is not actionable in its current state not reproing We're not able to reproduce the issue (it's unlikely to get fixed until we find one). labels Apr 2, 2020
@sean-mcmanus
Copy link
Collaborator

It's working for me. Can you provide more repro details?

image

@ShukantPal
Copy link
Author

ShukantPal commented Apr 2, 2020

@sean-mcmanus

Screen Shot 2020-04-02 at 2 14 42 PM

Hi, I'm working on https://github.com/SurakartaArcade/libsurakarta. The screenshot is from include/skmove.h.

This is a non-exhaustive list of extensions on my system:

  • CMake Tools
  • C/C++
  • ESLint
  • Flow Support

If you are more specific, I can given you more repro details.

@sean-mcmanus sean-mcmanus added this to the Tracking milestone Apr 2, 2020
@sean-mcmanus
Copy link
Collaborator

Thanks for the info. I reproed it. The bug is triggered by the surrounding "namespace ". It appears to be an issue inherited from Visual Studio, so you can upvote https://developercommunity.visualstudio.com/content/problem/975899/c-intellisense-show-no-documentation-comment-for-t.html if you have a Microsoft account.

@sean-mcmanus sean-mcmanus added bug Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. Language Service Visual Studio Inherited from Visual Studio and removed Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. Language Service more info needed The issue report is not actionable in its current state not reproing We're not able to reproduce the issue (it's unlikely to get fixed until we find one). labels Apr 2, 2020
@sean-mcmanus sean-mcmanus removed this from the Tracking milestone Jul 15, 2020
@sean-mcmanus sean-mcmanus removed the Visual Studio Inherited from Visual Studio label Jul 15, 2020
@sean-mcmanus
Copy link
Collaborator

VS fixed it in a component that isn't shared yet, i.e. we'd need to make a different fix.

@sean-mcmanus sean-mcmanus added the Works in VS So we'd need to fix it for VS Code to reach parity. label Jul 15, 2020
@bobbrow bobbrow added this to the Backlog milestone Jul 16, 2020
@Colengms Colengms changed the title Doesn't show documentation for typedef Doesn't show documentation for typedef in a namespace Nov 5, 2020
@Colengms Colengms modified the milestones: Backlog, Unification Mar 4, 2021
@db-src
Copy link

db-src commented Jun 14, 2023

Sorry to be 'that guy', but since it's been around two years... It would be great if this could be fixed. Is there any idea of an updated ETA?

@sean-mcmanus
Copy link
Collaborator

@db-src @ShukantPal Sorry about that and thanks for the "ping" -- it looks like this "fell through the cracks" -- it was trivial to apply the fix that VS made. It should be fixed in our next update.

@sean-mcmanus sean-mcmanus modified the milestones: Unification, 1.17.0 Jun 26, 2023
@db-src
Copy link

db-src commented Jun 27, 2023

Brilliant, thank you!

@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 27, 2023
@michelleangela
Copy link
Contributor

Fix available in pre-release https://github.com/microsoft/vscode-cpptools/releases/tag/v1.17.0.

@michelleangela
Copy link
Contributor

@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Development

No branches or pull requests

6 participants