Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Developer Command Prompt for VS" should not be translated in our strings #12909

Open
bobbrow opened this issue Oct 30, 2024 · 4 comments · Fixed by #13093
Open

"Developer Command Prompt for VS" should not be translated in our strings #12909

bobbrow opened this issue Oct 30, 2024 · 4 comments · Fixed by #13093
Assignees
@sean-mcmanus
Labels
bug Documentation Request fixed Check the Milestone for the release in which the fix is or will be available. world ready An issue relating string character encodings, localization translations, etc.
Milestone
1.24

Comments

@bobbrow
Copy link
Member

bobbrow commented Oct 30, 2024

We need to communicate to the Loc team that "Developer Command Prompt for VS" should not be translated.

RE: #12439
@bobbrow bobbrow added this to cpptools Oct 30, 2024
@bobbrow bobbrow moved this to Todo in cpptools Oct 30, 2024
@bobbrow bobbrow added the world ready An issue relating string character encodings, localization translations, etc. label Oct 30, 2024
@sean-mcmanus
Copy link
Contributor

@bobbrow What were you thinking in regards to how that should be communicated?

@bobbrow
Copy link
Member Author

bobbrow commented Nov 19, 2024

I didn't look into it that much, but I think the root of this issue is that we need to add notes to the translators with our strings. However, I know that some of them are in the walkthrough or HTML and we might need to update our string scraping scripts to parse out something new to pass that information along.

@sean-mcmanus sean-mcmanus self-assigned this Dec 16, 2024
@sean-mcmanus sean-mcmanus moved this from Todo to In progress in cpptools Dec 16, 2024
This was referenced Dec 31, 2024
Merged
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in cpptools Jan 2, 2025
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 2, 2025
@sean-mcmanus sean-mcmanus modified the milestones: 1.23.3, 1.23 Jan 2, 2025
@sean-mcmanus sean-mcmanus modified the milestones: 1.23, 1.24.0 Jan 22, 2025
@sean-mcmanus sean-mcmanus reopened this Jan 22, 2025
@sean-mcmanus
Copy link
Contributor

Some of the strings got fixed, but I added "hints" to the strings saying to not translate the Developer Command Prompt but they did not follow the hints so I need to file bugs.

@sean-mcmanus sean-mcmanus reopened this Jan 22, 2025
@v-ericawu
Copy link

Tested on C/C++ 1.23.4(pre-release), this issue still repro:
ENU:
Image

CHS:
Image

@sean-mcmanus sean-mcmanus modified the milestones: 1.24.0, 1.24 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sean-mcmanus sean-mcmanus

Labels
bug Documentation Request fixed Check the Milestone for the release in which the fix is or will be available. world ready An issue relating string character encodings, localization translations, etc.
Projects
cpptools
Status: Done
Milestone
1.24
Development

Successfully merging a pull request may close this issue.

Fix other developer command prompt cases, and "developer" and "code" … microsoft/vscode-cpptools
3 participants
@bobbrow @sean-mcmanus @v-ericawu