Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix for missing header file #10791

Closed
M1Z3 opened this issue Apr 9, 2023 · 3 comments
Closed

Quickfix for missing header file #10791

M1Z3 opened this issue Apr 9, 2023 · 3 comments
Assignees
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@M1Z3
Copy link

M1Z3 commented Apr 9, 2023

Feature Request

During development it is cumbersome to add missing header files. There should be a quickfix option on an unknown symbol which adds the corresponding header to the current file.

quickfix_for_symbolspng

The languageClient in src/LanguageServer/client.ts can be used to query the symbol information and determine the header location. I already implemented the feature as a draft ;)

@Mazhar012
Copy link

add include

@bobbrow bobbrow modified the milestones: Backlog, 1.18, On Deck Aug 3, 2023
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.18.1 Oct 31, 2023
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Oct 31, 2023
@sean-mcmanus
Copy link
Collaborator

@M1Z3
Copy link
Author

M1Z3 commented Nov 17, 2023

@M1Z3 This is available in 1.18.4. Some known issues are https://github.com/microsoft/vscode-cpptools/issues?q=is%3Aopen+is%3Aissue+label%3A%22Feature%3A+Add+%27%23include%27%22

Thanks for the heads-up :)! I followed the activity on this issue and already tested it on pre-release. It seems to work for system headers 🎉

As far as I can see this #10792 is not needed anymore. So I'm going to close it 😉

@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants