Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy support for extended floating-point types #10610

Closed
sean-mcmanus opened this issue Feb 28, 2023 Discussed in #10595 · 4 comments
Closed

clang-tidy support for extended floating-point types #10610

sean-mcmanus opened this issue Feb 28, 2023 Discussed in #10595 · 4 comments
Assignees
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix verified Bug has been reproduced
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

Discussed in #10595

Originally posted by blackteahamburger February 25, 2023
With

"C_Cpp.default.cppStandard": "c++23",
"C_Cpp.default.compilerPath": "/usr/bin/g++-13"

The following code:

int main()
{
    _Float16 f;
}

causes _Float16 is not supported on this target C/C++(clang-diagnostic-error).

However, running clang-tidy directly produces no warnings or errors.

@sean-mcmanus sean-mcmanus added bug Language Service verified Bug has been reproduced Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. labels Feb 28, 2023
@sean-mcmanus sean-mcmanus added this to the 1.15 milestone Feb 28, 2023
@sean-mcmanus sean-mcmanus self-assigned this Feb 28, 2023
@sean-mcmanus
Copy link
Collaborator Author

@blackteahamburger You can use "C_Cpp.codeAnalysis.clangTidy.args": ["--extra-arg=-msse2"] as a workaround.

@sean-mcmanus sean-mcmanus modified the milestones: 1.15, 1.15.0 Mar 1, 2023
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 1, 2023
@sean-mcmanus
Copy link
Collaborator Author

The fix is available with 1.15.0 (pre-release): https://github.com/microsoft/vscode-cpptools/releases/tag/v1.15.0

@blackteahamburger
Copy link

The fix is available with 1.15.0 (pre-release): https://github.com/microsoft/vscode-cpptools/releases/tag/v1.15.0

However, there is still no _Float32, _Float64 or _Float128 support.

@sean-mcmanus
Copy link
Collaborator Author

@blackteahamburger That is due to clang(-tidy) itself not having support for that.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix verified Bug has been reproduced
Projects
None yet
Development

No branches or pull requests

2 participants