-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Status follow up for compilerPath #10527
Comments
I would prefer something like "Configure IntelliSense" over "Improve IntelliSense". Was there a reason to use "improve" instead? |
IntelliSense is already "configured" albeit incorrectly. This makes the configuration better. |
I don't understand. If no compiler is configured then we've selected one on own. To "configure" implies "an explicit action to configure something correctly". The verb "improve" seems too generic and seems to imply that the link will enable IntelliSense to be better, faster, more accurate, etc., when it's really just "configuring" to work correctly with a particular compiler. For example, the command "CMake: Configure" would be strange to rename "CMake: Improve". Unless I'm misunderstanding something. |
I believe this is for the case where we would have shown the prompt to confirm our compiler selection. If they dismiss that, we don't have a compiler at all. We configure without it. I'm not particular about the text here. Please sync with @AlexandraKemperMS and come to a consensus if you would like to have different text. |
This issue has been replaced by #10685 |
When no compiler is configured, the link for IntelliSense Status in the Language Status flyout should run the "select a compiler" command. Alex's suggested text for the link is "Improve IntelliSense."
The text was updated successfully, but these errors were encountered: