Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving may fail while code analysis is running due to willSaveWaitUntil returning before the file lock is actually released #10482

Closed
sean-mcmanus opened this issue Feb 7, 2023 · 0 comments
Closed

Saving may fail while code analysis is running due to willSaveWaitUntil returning before the file lock is actually released #10482

sean-mcmanus opened this issue Feb 7, 2023 · 0 comments
Assignees
@sean-mcmanus
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone
1.15.0

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Feb 7, 2023 •
edited
Loading

It seems like we may be returning too soon, not sure why yet. I have a case which very easily repros it.

Previously, we thought it was a VS Code bug (microsoft/vscode#164841).

Cases:
[x]: Save of source files (on Windows).
[x]: Save of source file with a 2nd save too soon.
[x]: Save of header files.
[x]: Check Linux/Mac difference?
@sean-mcmanus sean-mcmanus added bug Language Service investigate: repro This issue's repro steps needs to be investigated/confirmed Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. labels Feb 7, 2023
@sean-mcmanus sean-mcmanus added this to the 1.14 milestone Feb 7, 2023
@sean-mcmanus sean-mcmanus self-assigned this Feb 7, 2023
@bobbrow bobbrow modified the milestones: 1.14, On Deck Feb 9, 2023
@sean-mcmanus sean-mcmanus removed the investigate: repro This issue's repro steps needs to be investigated/confirmed label Mar 2, 2023
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.15 Mar 2, 2023
@sean-mcmanus sean-mcmanus modified the milestones: 1.15, 1.15.0 Mar 10, 2023
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sean-mcmanus sean-mcmanus

Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
2 participants
@bobbrow @sean-mcmanus