Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send clang-format arguments that aren't supported by its version #10178

Closed
sean-mcmanus opened this issue Nov 22, 2022 · 1 comment
Closed
Assignees
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

    @sean-mcmanus #10072 Makes it impossible to use older versions (< 12) of clang-format, which don't have `--Wno-error=unknown` yet. 

The default version of the clang-format package in Ubuntu <= 20.04 cannot handle this option. Additionally, older versions of clang-format are still widely in use in my experience due to how formatting changes often between different versions.

I would therefore argue that the change from #10072 should not be published without an accompanying solution to this issue.

Originally posted by @saierd in #10102 (comment)

@sean-mcmanus
Copy link
Collaborator Author

This should enable clang-format 11 or older (regressed from 1.13.4) and clang-format 8 or older (which would fail with the default
"Visual Studio" style with 1.12.4 and earlier versions)...I think we still have a minimum requirement of like clang 4 or so though, but those versions seem too old to worry about.

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

No branches or pull requests

1 participant